Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2916843002: Move StyleMultiColData::RuleWidth to ComputedStyle. (Closed)

Created:
3 years, 6 months ago by shend
Modified:
3 years, 6 months ago
Reviewers:
meade_UTC10
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move StyleMultiColData::RuleWidth to ComputedStyle. When we generate StyleMultiColData, we would no longer have the RuleWidth method because it is handwritten on StyleMultiColData. This patch moves RuleWidth to be inline in ComputedStyle so that we can generate StyleMultiColData. BUG=628043 Review-Url: https://codereview.chromium.org/2916843002 Cr-Commit-Position: refs/heads/master@{#476560} Committed: https://chromium.googlesource.com/chromium/src/+/88112f9e6ce26835980ae32867c5cdbbe36840a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleMultiColData.h View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
shend
Hi Eddy, PTAL
3 years, 6 months ago (2017-06-02 00:43:07 UTC) #6
meade_UTC10
lgtm
3 years, 6 months ago (2017-06-02 04:04:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2916843002/1
3 years, 6 months ago (2017-06-02 04:06:20 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 04:11:16 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/88112f9e6ce26835980ae32867c5...

Powered by Google App Engine
This is Rietveld 408576698