Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 2916803004: [System-Keyboard-Lock] Recover keyboard lock related tests (Closed)

Created:
3 years, 6 months ago by Hzj_jie
Modified:
3 years, 6 months ago
Reviewers:
qyearsley
CC:
blink-reviews, chromium-reviews, jeffcarp
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[System-Keyboard-Lock] Recover keyboard lock related tests The tests for keyboard lock have been wrongly annotated in W3CImportExpectations. So they have been removed by change https://chromium-review.googlesource.com/c/499507/. So this change annotates these tests as Pass; so they will be correctly imported next time. BUG=680809 Review-Url: https://codereview.chromium.org/2916803004 Cr-Commit-Position: refs/heads/master@{#476718} Committed: https://chromium.googlesource.com/chromium/src/+/031af3b98c849f80b3a8bb04f1727eb988070582

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/W3CImportExpectations View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
Hzj_jie
3 years, 6 months ago (2017-06-02 01:54:08 UTC) #6
qyearsley
LGTM
3 years, 6 months ago (2017-06-02 03:02:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2916803004/1
3 years, 6 months ago (2017-06-02 17:56:00 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 18:02:25 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/031af3b98c849f80b3a8bb04f172...

Powered by Google App Engine
This is Rietveld 408576698