Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 2916803003: Extract SelectionPaintRange calculation from LayoutSelection::Commit() (Closed)

Created:
3 years, 6 months ago by yoichio
Modified:
3 years, 6 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Extract SelectionPaintRange calculation from LayoutSelection::Commit() This CL introduces CalcSelectionPaintRange() and minimize Commit(). BUG=708453 Review-Url: https://codereview.chromium.org/2916803003 Cr-Commit-Position: refs/heads/master@{#476234} Committed: https://chromium.googlesource.com/chromium/src/+/3b6c0e0cda44ef86b480a3c9604417d78f6ac650

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -21 lines) Patch
M third_party/WebKit/Source/core/editing/LayoutSelection.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/LayoutSelection.cpp View 1 3 chunks +29 lines, -18 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
yoichio
3 years, 6 months ago (2017-06-01 09:13:57 UTC) #12
yosin_UTC9
lgtm
3 years, 6 months ago (2017-06-01 09:20:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2916803003/20001
3 years, 6 months ago (2017-06-01 09:21:08 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 09:25:35 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3b6c0e0cda44ef86b480a3c96044...

Powered by Google App Engine
This is Rietveld 408576698