third_party/WebKit/Source/devtools/front_end/timeline/TimelineHistoryManager.js - Issue 2916743002: [DevTools] Introduce Common.List used as a backend for list controls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineHistoryManager.js

Issue 2916743002: [DevTools] Introduce Common.List used as a backend for list controls (Closed)

Patch Set: Tests.js Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/Tests.js ('K') | « third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js ('k') | third_party/WebKit/Source/devtools/front_end/ui/ListControl.js » ('j') | third_party/WebKit/Source/devtools/front_end/ui/ListControl.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineHistoryManager.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineHistoryManager.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineHistoryManager.js

index 68ffb79f8765752401a1202bf9a1d7694d8acc41..8e2522b544452d8c95872a24f3c79071613ddc64 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineHistoryManager.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineHistoryManager.js

@@ -253,9 +253,10 @@ Timeline.TimelineHistoryManager.DropDown = class {

UI.createShadowRootWithCoreStyles(this._glassPane.contentElement, 'timeline/timelineHistoryManager.css');

var contentElement = shadowRoot.createChild('div', 'drop-down');

- this._listControl = new UI.ListControl(this, UI.ListMode.NonViewport);

+ var listModel = new UI.ListModel();

+ this._listControl = new UI.ListControl(listModel, this, UI.ListMode.NonViewport);

this._listControl.element.addEventListener('mousemove', this._onMouseMove.bind(this), false);

- this._listControl.replaceAllItems(models);

+ listModel.replaceAllItems(models);

contentElement.appendChild(this._listControl.element);

contentElement.addEventListener('keydown', this._onKeyDown.bind(this), false);