Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: third_party/WebKit/Source/devtools/front_end/Tests.js

Issue 2916743002: [DevTools] Introduce Common.List used as a backend for list controls (Closed)
Patch Set: Tests.js Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/Tests.js
diff --git a/third_party/WebKit/Source/devtools/front_end/Tests.js b/third_party/WebKit/Source/devtools/front_end/Tests.js
index 69f72fd364e757d38ee2fec73e93329e2fb22266..70dab2757244ebb592ca97d63f2ed900e36dccb2 100644
--- a/third_party/WebKit/Source/devtools/front_end/Tests.js
+++ b/third_party/WebKit/Source/devtools/front_end/Tests.js
@@ -847,10 +847,10 @@
function onExecutionContexts() {
var consoleView = Console.ConsoleView.instance();
- var items = consoleView._consoleContextSelector._list._items;
+ var items = consoleView._consoleContextSelector._items;
var values = [];
- for (var i = 0; i < items.length; ++i)
- values.push(consoleView._consoleContextSelector._titleFor(items[i]));
+ for (var i = 0; i < items.length(); ++i)
caseq 2017/06/01 01:37:56 Make it iterable?
dgozman 2017/06/01 20:31:49 I'll follow up.
+ values.push(consoleView._consoleContextSelector._titleFor(items.itemAtIndex(i)));
test.assertEquals('top', values[0]);
test.assertEquals('Simple content script', values[1]);
test.releaseControl();

Powered by Google App Engine
This is Rietveld 408576698