third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js - Issue 2916743002: [DevTools] Introduce Common.List used as a backend for list controls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js

Issue 2916743002: [DevTools] Introduce Common.List used as a backend for list controls (Closed)

Patch Set: Tests.js Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-list-widget-providers.js » ('j') | third_party/WebKit/Source/devtools/front_end/Tests.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js b/third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js

index 226c642d7b72bce57fa67335deb230f8f51ca5ba..7fc09aeceddff0879e9f2a5acbab084ee52cd095 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js

@@ -33,10 +33,10 @@ function test() {

function dump()

{

TestRunner.addResult("Query:" + JSON.stringify(filteredSelectionDialog._value()));

- var list = filteredSelectionDialog._list;

+ var items = filteredSelectionDialog._items;

var output = [];

- for (var i = 0; i < list.length(); ++i)

- output.push(provider.itemKeyAt(list.itemAtIndex(i)));

+ for (var i = 0; i < items.length(); ++i)

caseq 2017/06/01 01:37:56 let's make length a getter?

dgozman 2017/06/01 20:31:49 I'll follow up.

+ output.push(provider.itemKeyAt(items.itemAtIndex(i)));

TestRunner.addResult("Output:" + JSON.stringify(output));

}