Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2916703004: cc: Improve performance of PaintOpBuffer::Playback with no ranges. (Closed)

Created:
3 years, 6 months ago by danakj
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

cc: Improve performance of PaintOpBuffer::Playback with no ranges. In this case we were constructing 2 vectors on each call to playback() which causes us to do malloc/free twice as well. Instead, define a static vector and pass that which recovers basically all the lost time. The other changes in NextOp try to improve the codegen, and seem to maybe have up to 1ms improvement of the remaining delta of 2ms from before cfc477b43f1c91e84e17180ee937728d6f496aa6, but it's in the noise. However I think it's nicer with less nesting and only writing the operator++ once anyways. BUG=726031 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2905383002 Cr-Original-Commit-Position: refs/heads/master@{#475936} Review-Url: https://codereview.chromium.org/2916703004 . Cr-Commit-Position: refs/branch-heads/3112@{#95} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/feb6693d3c26cef1c1a1bb8ee1b2af015c4fb31a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -23 lines) Patch
M cc/paint/paint_op_buffer.cc View 1 chunk +27 lines, -23 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
danakj
3 years, 6 months ago (2017-06-01 17:43:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
feb6693d3c26cef1c1a1bb8ee1b2af015c4fb31a.

Powered by Google App Engine
This is Rietveld 408576698