Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2916663002: Pass the path mapping via RefCountedData in ModuleInspector (Closed)

Created:
3 years, 6 months ago by Patrick Monette
Modified:
3 years, 6 months ago
Reviewers:
chrisha
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass the path mapping via RefCountedData in ModuleInspector The mapping was getting copied every invocation of InspectModule, which is pretty inefficient. Review-Url: https://codereview.chromium.org/2916663002 Cr-Commit-Position: refs/heads/master@{#476525} Committed: https://chromium.googlesource.com/chromium/src/+/a2751f9ef935334ec6f729af358580d77cf4d4e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M chrome/browser/conflicts/module_inspector_win.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/conflicts/module_inspector_win.cc View 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Patrick Monette
PTAL
3 years, 6 months ago (2017-05-31 19:28:49 UTC) #3
chrisha
lgtm
3 years, 6 months ago (2017-06-02 01:12:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2916663002/1
3 years, 6 months ago (2017-06-02 01:36:26 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 02:28:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a2751f9ef935334ec6f729af3585...

Powered by Google App Engine
This is Rietveld 408576698