Issue 2916633002: Remove TODOs from KernelConditionalExpression._inferExpression.

Issue 2916633002: Remove TODOs from KernelConditionalExpression._inferExpression. (Closed)

Created:
3 years, 6 months ago by Paul Berry

Modified:
3 years, 6 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Remove TODOs from KernelConditionalExpression._inferExpression. The code is correct as is (at least insofar as it matches analyzer's behavior). I've added a new test to verify this, and I've made a comment on the spec asking for it to be updated to match analyzer's behavior. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/54c57f00157b32003d1ba00fe27f034be7c87879

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -4 lines)			Patch
M	pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	pkg/front_end/test/fasta/kompile.status	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	pkg/front_end/testcases/inference/conditional_upwards_inference.dart	View	1 chunk	+19 lines, -0 lines	0 comments	Download
A	pkg/front_end/testcases/inference/conditional_upwards_inference.dart.direct.expect	View	1 chunk	+17 lines, -0 lines	0 comments	Download
A	pkg/front_end/testcases/inference/conditional_upwards_inference.dart.outline.expect	View	1 chunk	+10 lines, -0 lines	0 comments	Download
A	pkg/front_end/testcases/inference/conditional_upwards_inference.dart.strong.expect	View	1 chunk	+17 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

3 years, 6 months ago (2017-05-31 17:04:26 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
54c57f00157b32003d1ba00fe27f034be7c87879 (presubmit successful).