Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart

Issue 2916633002: Remove TODOs from KernelConditionalExpression._inferExpression. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/front_end/test/fasta/kompile.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
index aa8719b0e614e4a9920b80e44279d588eb610438..d911b3f4abfd3bc8c566a1d59889d8d52315cf41 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
@@ -279,13 +279,9 @@ class KernelConditionalExpression extends ConditionalExpression
inferrer.inferExpression(
condition, inferrer.coreTypes.boolClass.rawType, false);
}
- // TODO(paulberry): is it correct to pass the context down?
DartType thenType = inferrer.inferExpression(then, typeContext, true);
DartType otherwiseType =
inferrer.inferExpression(otherwise, typeContext, true);
- // TODO(paulberry): the spec proposal says we should only use LUB if the
- // typeContext is `null`. If typeContext is non-null, we should use the
- // greatest closure of the context with respect to `?`
DartType type = inferrer.typeSchemaEnvironment
.getLeastUpperBound(thenType, otherwiseType);
staticType = type;
« no previous file with comments | « no previous file | pkg/front_end/test/fasta/kompile.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698