Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2916433002:
Add more complete description for PageLoad UKM metrics. (Closed)
|
Created:
3 years, 6 months ago by Bryan McQuade Modified:
3 years, 6 months ago Reviewers:
rkaplow CC:
asvitkine+watch_chromium.org, chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd more complete description for PageLoad UKM metrics.
BUG=727823
Review-Url: https://codereview.chromium.org/2916433002
Cr-Commit-Position: refs/heads/master@{#475987}
Committed: https://chromium.googlesource.com/chromium/src/+/a02b12b891f2c49051e5e763e03c07df82e853f3
Patch Set 1 #Patch Set 2 : fix comments #Patch Set 3 : rebase #Messages
Total messages: 19 (15 generated)
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Add more complete description for PageLoad UKM metrics. BUG= ========== to ========== Add more complete description for PageLoad UKM metrics. BUG=727823 ==========
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
bmcquade@chromium.org changed reviewers: + rkaplow@chromium.org
PTAL, thanks!
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by bmcquade@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496257253815490,
"parent_rev": "cee832ae9d7ccde4dfc286a29918c263569fb67a", "commit_rev":
"a02b12b891f2c49051e5e763e03c07df82e853f3"}
Message was sent while issue was closed.
Description was changed from ========== Add more complete description for PageLoad UKM metrics. BUG=727823 ========== to ========== Add more complete description for PageLoad UKM metrics. BUG=727823 Review-Url: https://codereview.chromium.org/2916433002 Cr-Commit-Position: refs/heads/master@{#475987} Committed: https://chromium.googlesource.com/chromium/src/+/a02b12b891f2c49051e5e763e03c... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/a02b12b891f2c49051e5e763e03c... |
