Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issue 2916383005: Fix flaky CertificateReportingServiceBrowserTest.DontSendOldReports test (Closed)

Created:
3 years, 6 months ago by meacer
Modified:
3 years, 6 months ago
Reviewers:
Jialiu Lin, estark
CC:
chromium-reviews, grt+watch_chromium.org, vakh+watch_chromium.org, timvolodine
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flaky CertificateReportingServiceBrowserTest.DontSendOldReports test BUG=719138 Review-Url: https://codereview.chromium.org/2916383005 Cr-Commit-Position: refs/heads/master@{#477053} Committed: https://chromium.googlesource.com/chromium/src/+/123a65b6261c9aedc86ac67e5f270f9a9aa917bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M chrome/browser/safe_browsing/certificate_reporting_service_browsertest.cc View 2 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
meacer
estark: PTAL? I can't repro but it seems like the failure is caused by reports ...
3 years, 6 months ago (2017-06-03 00:07:00 UTC) #2
estark
lgtm
3 years, 6 months ago (2017-06-03 21:09:01 UTC) #3
meacer
jialiul, can you ptal as owner? Thanks.
3 years, 6 months ago (2017-06-05 17:28:44 UTC) #5
Jialiu Lin
LGTM
3 years, 6 months ago (2017-06-05 17:59:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2916383005/1
3 years, 6 months ago (2017-06-05 18:22:30 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-05 19:21:39 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/123a65b6261c9aedc86ac67e5f27...

Powered by Google App Engine
This is Rietveld 408576698