ThreadChecker instead of SequenceChecker in classes that use TLS.

ThreadChecker instead of SequenceChecker in classes that use TLS.

A few incorrect SequenceChecker slipped through reviews in mass migration
of base::NonThreadSafe. As documented on those CLs, usage of ThreadLocalStorage
requires thread-affinity (ThreadChecker instead of SequenceChecker).

BUG=676387
Review-Url: https://codereview.chromium.org/2916303002
Cr-Commit-Position: refs/heads/master@{#476742}
Committed: https://chromium.googlesource.com/chromium/src/+/17bf185c1ff5d8cc7f3a9d501e140136e3482911

[gab, 2017-06-02 14:46:27]

Description was changed from

==========
ThreadChecker instead of SequenceChecker in classes that use TLS.

A few incorrect SequenceChecker slipped through reviews in mass migration
of base::NonThreadSafe. As documented on those CLs, usage of ThreadLocalStorage
requires thread-affinity.

BUG=676387
==========

to

==========
ThreadChecker instead of SequenceChecker in classes that use TLS.

A few incorrect SequenceChecker slipped through reviews in mass migration
of base::NonThreadSafe. As documented on those CLs, usage of ThreadLocalStorage
requires thread-affinity (ThreadChecker instead of SequenceChecker).

BUG=676387
==========

[gab, 2017-06-02 14:46:34]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 14:46:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2017-06-02 14:48:02]

gab@chromium.org changed reviewers:
+ jianli@chromium.org, scottbyer@chromium.org

[gab, 2017-06-02 14:48:02]

Just surveyed the codebase for mix of SequenceChecker and ThreadLocal in the
same file.

@jianli: this is a follow-up to https://codereview.chromium.org/2915503002/

@scottbyer: this is a follow-up to https://codereview.chromium.org/2914573002

Thanks,
Gab

[commit-bot: I haz the power, 2017-06-02 14:59:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 14:59:06]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[gab, 2017-06-02 15:03:06]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 15:03:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Scott Byer, 2017-06-02 15:41:43]

lgtm

[commit-bot: I haz the power, 2017-06-02 17:13:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 17:13:27]

Dry run: This issue passed the CQ dry run.

[jianli, 2017-06-02 18:55:20]

fileapi lgtm

[gab, 2017-06-02 18:59:05]

@scottbyer: see note below about usage of TLS in
chrome/service/cloud_print/cloud_print_token_store.cc being overkill IMO

Thanks!
Gab

https://codereview.chromium.org/2916303002/diff/1/chrome/service/cloud_print/...
File chrome/service/cloud_print/cloud_print_token_store.cc (right):

https://codereview.chromium.org/2916303002/diff/1/chrome/service/cloud_print/...
chrome/service/cloud_print/cloud_print_token_store.cc:15:
base::ThreadLocalPointer<CloudPrintTokenStore>>::DestructorAtExit lazy_tls =
Note: this probably shouldn't use TLS. Given access is sequenced (per the
SequenceChecker). From the API "this is only used with
CloudPrintProxyCoreThread". As such this could be a global variable (no TLS) to
which thread-safe access is enforced by a SequenceChecker.

I'll let OWNERS address this in a follow-up.

[gab, 2017-06-02 18:59:10]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2017-06-02 18:59:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 19:05:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496429950493970,
"parent_rev": "ba0a42d0d3c05a9b9e5b125436e29b4a114b115f", "commit_rev":
"17bf185c1ff5d8cc7f3a9d501e140136e3482911"}

[commit-bot: I haz the power, 2017-06-02 19:05:57]

Description was changed from

==========
ThreadChecker instead of SequenceChecker in classes that use TLS.

A few incorrect SequenceChecker slipped through reviews in mass migration
of base::NonThreadSafe. As documented on those CLs, usage of ThreadLocalStorage
requires thread-affinity (ThreadChecker instead of SequenceChecker).

BUG=676387
==========

to

==========
ThreadChecker instead of SequenceChecker in classes that use TLS.

A few incorrect SequenceChecker slipped through reviews in mass migration
of base::NonThreadSafe. As documented on those CLs, usage of ThreadLocalStorage
requires thread-affinity (ThreadChecker instead of SequenceChecker).

BUG=676387

Review-Url: https://codereview.chromium.org/2916303002
Cr-Commit-Position: refs/heads/master@{#476742}
Committed:
https://chromium.googlesource.com/chromium/src/+/17bf185c1ff5d8cc7f3a9d501e14...
==========

[commit-bot: I haz the power, 2017-06-02 19:05:58]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/17bf185c1ff5d8cc7f3a9d501e14...