Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 2916293002: Correct the documentation of the plugin content settings policies. (Closed)

Created:
3 years, 6 months ago by pastarmovj
Modified:
3 years, 6 months ago
Reviewers:
Thiemo Nagel
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Correct the documentation of the plugin content settings policies. The DefaultPluginSettings as well as its white- and blacklist policies are now only related to the Flash plugin and has no effect on the other left plugin - the PDF viewer. BUG=728981 TEST=none - documentation only change. Review-Url: https://codereview.chromium.org/2916293002 Cr-Commit-Position: refs/heads/master@{#476634} Committed: https://chromium.googlesource.com/chromium/src/+/4cb7c3991639f0275c790e357cf80d3a0565a028

Patch Set 1 #

Patch Set 2 : Fix PH tags. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M components/policy/resources/policy_templates.json View 1 4 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
pastarmovj
Hi Thiemo, can you please review this change to the policy templates. Thanks, Julian
3 years, 6 months ago (2017-06-02 10:09:26 UTC) #2
Thiemo Nagel
Lgtm. Thanks!
3 years, 6 months ago (2017-06-02 10:15:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2916293002/1
3 years, 6 months ago (2017-06-02 10:32:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/468718)
3 years, 6 months ago (2017-06-02 10:45:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2916293002/20001
3 years, 6 months ago (2017-06-02 11:07:03 UTC) #10
Thiemo Nagel
Still lgtm.
3 years, 6 months ago (2017-06-02 11:19:56 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/309137)
3 years, 6 months ago (2017-06-02 12:42:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2916293002/20001
3 years, 6 months ago (2017-06-02 13:05:02 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 14:05:24 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4cb7c3991639f0275c790e357cf8...

Powered by Google App Engine
This is Rietveld 408576698