Call glReleaseShaderCompiler when GLRenderer loses visibility.

Call glReleaseShaderCompiler when GLRenderer loses visibility.

This call is a hint that the driver should release RAM caches that it
may have built to optimize shader compilation from strings.  We should
call it to save RAM when we expect that we will not be compiling any
shaders anytime soon.  The browser going into background is a simple,
deterministic time where we can establish that.

Notes:
- On Android, visibility loss results in GLRenderer (and
Display) destruction instead of a SetVisibility call, so also add a
call in CleanupSharedObjects().
- I plan to hook up ANGLE ShaderTranslatorCache clearing to this signal
in a later patch, as mentioned in the TODO in shader_translator_cache.h.

BUG=725306, 725303
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2916263002
Cr-Commit-Position: refs/heads/master@{#476740}
Committed: https://chromium.googlesource.com/chromium/src/+/620bb1e36c3e115f91473d366035acf7dc933ec4

[aelias_OOO_until_Jul13, 2017-06-02 01:22:16]

Description was changed from

==========
Call glReleaseShaderCompiler when GLRenderer loses visibility.

This call is a hint that the driver should release RAM caches that it
may have built to optimize shader compilation from strings.  We should
call it to save RAM when we expect that we will not be compiling any
shaders anytime soon.  The browser going into background is a simple,
deterministic time where we can establish that.

Note that on Android, visibility loss results in GLRenderer (and
Display) destruction instead of a SetVisibility call, so also add a
call in CleanupSharedObjects().

BUG=725306,725306
==========

to

==========
Call glReleaseShaderCompiler when GLRenderer loses visibility.

This call is a hint that the driver should release RAM caches that it
may have built to optimize shader compilation from strings.  We should
call it to save RAM when we expect that we will not be compiling any
shaders anytime soon.  The browser going into background is a simple,
deterministic time where we can establish that.

Note that on Android, visibility loss results in GLRenderer (and
Display) destruction instead of a SetVisibility call, so also add a
call in CleanupSharedObjects().

BUG=725306,725306
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[aelias_OOO_until_Jul13, 2017-06-02 01:23:42]

Description was changed from

==========
Call glReleaseShaderCompiler when GLRenderer loses visibility.

This call is a hint that the driver should release RAM caches that it
may have built to optimize shader compilation from strings.  We should
call it to save RAM when we expect that we will not be compiling any
shaders anytime soon.  The browser going into background is a simple,
deterministic time where we can establish that.

Note that on Android, visibility loss results in GLRenderer (and
Display) destruction instead of a SetVisibility call, so also add a
call in CleanupSharedObjects().

BUG=725306,725306
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Call glReleaseShaderCompiler when GLRenderer loses visibility.

This call is a hint that the driver should release RAM caches that it
may have built to optimize shader compilation from strings.  We should
call it to save RAM when we expect that we will not be compiling any
shaders anytime soon.  The browser going into background is a simple,
deterministic time where we can establish that.

Note that on Android, visibility loss results in GLRenderer (and
Display) destruction instead of a SetVisibility call, so also add a
call in CleanupSharedObjects().

BUG=725306,725303
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[aelias_OOO_until_Jul13, 2017-06-02 01:23:54]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 01:24:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aelias_OOO_until_Jul13, 2017-06-02 01:27:00]

Description was changed from

==========
Call glReleaseShaderCompiler when GLRenderer loses visibility.

This call is a hint that the driver should release RAM caches that it
may have built to optimize shader compilation from strings.  We should
call it to save RAM when we expect that we will not be compiling any
shaders anytime soon.  The browser going into background is a simple,
deterministic time where we can establish that.

Note that on Android, visibility loss results in GLRenderer (and
Display) destruction instead of a SetVisibility call, so also add a
call in CleanupSharedObjects().

BUG=725306,725303
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Call glReleaseShaderCompiler when GLRenderer loses visibility.

This call is a hint that the driver should release RAM caches that it
may have built to optimize shader compilation from strings.  We should
call it to save RAM when we expect that we will not be compiling any
shaders anytime soon.  The browser going into background is a simple,
deterministic time where we can establish that.

Notes:
- On Android, visibility loss results in GLRenderer (and
Display) destruction instead of a SetVisibility call, so also add a
call in CleanupSharedObjects().
- I plan to hook up ANGLE ShaderTranslatorCache clearing to this signal
in a later patch, as mentioned in the TODO in shader_translator_cache.h.

BUG=725306,725303
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[aelias_OOO_until_Jul13, 2017-06-02 01:31:15]

aelias@chromium.org changed reviewers:
+ piman@chromium.org

[aelias_OOO_until_Jul13, 2017-06-02 01:31:28]

Hi piman@, PTAL.

[commit-bot: I haz the power, 2017-06-02 03:22:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 03:22:01]

Dry run: This issue passed the CQ dry run.

[rclacy36a, 2017-06-02 03:29:37]

On 2017/06/02 01:23:42, aelias wrote:
> Description was changed from
> 
> ==========
> Call glReleaseShaderCompiler when GLRenderer loses visibility.
> 
> This call is a hint that the driver should release RAM caches that it
> may have built to optimize shader compilation from strings.  We should
> call it to save RAM when we expect that we will not be compiling any
> shaders anytime soon.  The browser going into background is a simple,
> deterministic time where we can establish that.
> 
> Note that on Android, visibility loss results in GLRenderer (and
> Display) destruction instead of a SetVisibility call, so also add a
> call in CleanupSharedObjects().
> 
> BUG=725306,725306
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> ==========
> 
> to
> 
> ==========
> Call glReleaseShaderCompiler when GLRenderer loses visibility.
> 
> This call is a hint that the driver should release RAM caches that it
> may have built to optimize shader compilation from strings.  We should
> call it to save RAM when we expect that we will not be compiling any
> shaders anytime soon.  The browser going into background is a simple,
> deterministic time where we can establish that.
> 
> Note that on Android, visibility loss results in GLRenderer (and
> Display) destruction instead of a SetVisibility call, so also add a
> call in CleanupSharedObjects().
> 
> BUG=725306,725303
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> ==========

[piman, 2017-06-02 17:09:33]

lgtm

[aelias_OOO_until_Jul13, 2017-06-02 18:50:22]

The CQ bit was checked by aelias@chromium.org

[commit-bot: I haz the power, 2017-06-02 18:50:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 18:55:56]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496429422292880, "parent_rev":
"a11e7c542d5bcd2bb7776830660baf73ba85d4b0", "commit_rev":
"620bb1e36c3e115f91473d366035acf7dc933ec4"}

[commit-bot: I haz the power, 2017-06-02 18:56:04]

Description was changed from

==========
Call glReleaseShaderCompiler when GLRenderer loses visibility.

This call is a hint that the driver should release RAM caches that it
may have built to optimize shader compilation from strings.  We should
call it to save RAM when we expect that we will not be compiling any
shaders anytime soon.  The browser going into background is a simple,
deterministic time where we can establish that.

Notes:
- On Android, visibility loss results in GLRenderer (and
Display) destruction instead of a SetVisibility call, so also add a
call in CleanupSharedObjects().
- I plan to hook up ANGLE ShaderTranslatorCache clearing to this signal
in a later patch, as mentioned in the TODO in shader_translator_cache.h.

BUG=725306,725303
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Call glReleaseShaderCompiler when GLRenderer loses visibility.

This call is a hint that the driver should release RAM caches that it
may have built to optimize shader compilation from strings.  We should
call it to save RAM when we expect that we will not be compiling any
shaders anytime soon.  The browser going into background is a simple,
deterministic time where we can establish that.

Notes:
- On Android, visibility loss results in GLRenderer (and
Display) destruction instead of a SetVisibility call, so also add a
call in CleanupSharedObjects().
- I plan to hook up ANGLE ShaderTranslatorCache clearing to this signal
in a later patch, as mentioned in the TODO in shader_translator_cache.h.

BUG=725306,725303
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2916263002
Cr-Commit-Position: refs/heads/master@{#476740}
Committed:
https://chromium.googlesource.com/chromium/src/+/620bb1e36c3e115f91473d366035...
==========

[commit-bot: I haz the power, 2017-06-02 18:56:06]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/620bb1e36c3e115f91473d366035...