Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2916253003: [ObjC ARC] Converts ios/chrome/browser/crash_report:crash_report_internal to ARC. (Closed)

Created:
3 years, 6 months ago by pkl (ping after 24h if needed)
Modified:
3 years, 6 months ago
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/crash_report:crash_report_internal to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2916253003 Cr-Commit-Position: refs/heads/master@{#478604} Committed: https://chromium.googlesource.com/chromium/src/+/490d666042ff57a78a5e4f990793f375f626212f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -22 lines) Patch
M ios/chrome/browser/crash_report/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/crash_report/crash_report_helper.mm View 8 chunks +16 lines, -16 lines 0 comments Download
M ios/chrome/browser/crash_report/crash_restore_helper.mm View 4 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
pkl (ping after 24h if needed)
PTAL
3 years, 6 months ago (2017-06-02 21:22:55 UTC) #6
rohitrao (ping after 24h)
lgtm but please wait for stk
3 years, 6 months ago (2017-06-05 14:30:24 UTC) #7
pkl (ping after 24h if needed)
stk: ping
3 years, 6 months ago (2017-06-07 05:05:09 UTC) #8
sdefresne
On 2017/06/07 05:05:09, pkl -pls.ping.after.24h. wrote: > stk: ping stk is OOO for the week.
3 years, 6 months ago (2017-06-07 08:46:26 UTC) #9
stkhapugin
lgtm lgtm
3 years, 6 months ago (2017-06-12 12:19:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2916253003/1
3 years, 6 months ago (2017-06-12 12:19:21 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 13:59:47 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/490d666042ff57a78a5e4f990793...

Powered by Google App Engine
This is Rietveld 408576698