[CacheStorage] [IndexedDB] [DevTools] Added refresh button to category view of cache storage and in…

Added refresh button to category view of cache storage and indexeddb

BUG=727920, 727897
Review-Url: https://codereview.chromium.org/2916193003
Cr-Commit-Position: refs/heads/master@{#478099}
Committed: https://chromium.googlesource.com/chromium/src/+/423c0eff455de15f2e3f0cc6c54002fa9b7db5a6

[kristipark, 2017-06-01 23:10:03]

Description was changed from

==========
[CacheStorage] [IndexedDB] [DevTools] Added refresh button to category view of
cache storage and indexeddb

BUG=727920, 727897
==========

to

==========
Added refresh button to category view of cache storage and indexeddb

BUG=727920, 727897
==========

[kristipark, 2017-06-01 23:10:04]

kristipark@chromium.org changed reviewers:
+ dgozman@chromium.org, dmurph@chromium.org

[dgozman, 2017-06-02 18:36:52]

dgozman@chromium.org changed reviewers:
+ eostroukhov@chromium.org

[dgozman, 2017-06-02 18:36:53]

+Eugene

https://codereview.chromium.org/2916193003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js
(right):

https://codereview.chromium.org/2916193003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js:32: *
@unrestricted
No need for unrestricted.

https://codereview.chromium.org/2916193003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js:41:
this._reportView = new UI.ReportView('IndexedDB');
You can just use |var reportView| and not save to this. Same for other
variables.

https://codereview.chromium.org/2916193003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js
(right):

https://codereview.chromium.org/2916193003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js:15:
this._reportView = new UI.ReportView('Cache Storage');
Do we actually need a report view? Let's just add a single button to
this.contentElement?

[kristipark, 2017-06-06 01:27:31]

Switched to section refresh buttons instead of category view as recommended by
Dmitry.

Unfortunately, placing the buttons on the far right edge of the sidebar caused
it to become hidden if any expanded tree elements were wider than the sidebar
window (overflow). I placed the buttons next to the section title instead.

[dgozman, 2017-06-06 20:40:54]

On 2017/06/06 01:27:31, kristipark wrote:
> Switched to section refresh buttons instead of category view as recommended by
> Dmitry.
> 
> Unfortunately, placing the buttons on the far right edge of the sidebar caused
> it to become hidden if any expanded tree elements were wider than the sidebar
> window (overflow). I placed the buttons next to the section title instead.

Please upload a screenshot to the bug for UI changes, especially since it
differs from the discussion. Code lgtm.

[kristipark, 2017-06-06 20:55:36]

On 2017/06/06 20:40:54, dgozman wrote:
> On 2017/06/06 01:27:31, kristipark wrote:
> > Switched to section refresh buttons instead of category view as recommended
by
> > Dmitry.
> > 
> > Unfortunately, placing the buttons on the far right edge of the sidebar
caused
> > it to become hidden if any expanded tree elements were wider than the
sidebar
> > window (overflow). I placed the buttons next to the section title instead.
> 
> Please upload a screenshot to the bug for UI changes, especially since it
> differs from the discussion. Code lgtm.

Sorry about that, I uploaded a screenshot!
https://bugs.chromium.org/p/chromium/issues/detail?id=727897

[kristipark, 2017-06-08 19:51:37]

The CQ bit was checked by kristipark@chromium.org

[commit-bot: I haz the power, 2017-06-08 19:52:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 21:48:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496951497477830,
"parent_rev": "aae1e1ce18a9b1923ea7bdfafa5f3afe46050532", "commit_rev":
"423c0eff455de15f2e3f0cc6c54002fa9b7db5a6"}

[commit-bot: I haz the power, 2017-06-08 21:49:04]

Description was changed from

==========
Added refresh button to category view of cache storage and indexeddb

BUG=727920, 727897
==========

to

==========
Added refresh button to category view of cache storage and indexeddb

BUG=727920, 727897

Review-Url: https://codereview.chromium.org/2916193003
Cr-Commit-Position: refs/heads/master@{#478099}
Committed:
https://chromium.googlesource.com/chromium/src/+/423c0eff455de15f2e3f0cc6c540...
==========

[commit-bot: I haz the power, 2017-06-08 21:49:07]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/423c0eff455de15f2e3f0cc6c540...

[pfeldman, 2017-07-06 20:12:54]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2973113002/ by pfeldman@chromium.org.

The reason for reverting is: The UI does not look right..