Reset |most_recent_bounds_| on new Overlay

Reset |most_recent_bounds_| on new Overlay

When overlays are enabled, on Nexus 5 devices, upon exiting and
re-entering fullscreen, nothing is displayed on screen.

This is caused by the fact that AVDACodecImage never resets
|most_recent_bounds_| when a new overlay is received. This means
AndroidOverlay::ScheduleLayout() is never called in
AVDACodecImage::ScheduleOverlayPlane(), and new overlays retains their
initial bounds of [0,0,1,1].

This CL fixes the issue by reseting the bounds when a new shared state
(and therefore potential new Overlay) is set.

BUG=728802
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2916193002
Cr-Commit-Position: refs/heads/master@{#476524}
Committed: https://chromium.googlesource.com/chromium/src/+/d1fdad9d1437cad3bcdc373c02fbc10f7704252e

[tguilbert, 2017-06-01 21:48:59]

Description was changed from

==========
Reset |most_recent_bounds_| on new Overlay

When overlays are enabled, on Nexus 5 devices, upon exiting and
re-entering fullscreen, nothing is displayed on screen.

This is caused by the fact that AVDACodecImage never resets
|most_recent_bounds_| when a new overlay is received. This means
AndroidOverlay::ScheduleLayout() is never called in
AVDACodecImage::ScheduleOverlayPlane(), and new overlays retains their
initial bounds of [0,0,1,1].

This CL fixes the issue by reseting the bounds when a new shared state
(and therefore potential new Overlay) is set.

BUG=728802
==========

to

==========
Reset |most_recent_bounds_| on new Overlay

When overlays are enabled, on Nexus 5 devices, upon exiting and
re-entering fullscreen, nothing is displayed on screen.

This is caused by the fact that AVDACodecImage never resets
|most_recent_bounds_| when a new overlay is received. This means
AndroidOverlay::ScheduleLayout() is never called in
AVDACodecImage::ScheduleOverlayPlane(), and new overlays retains their
initial bounds of [0,0,1,1].

This CL fixes the issue by reseting the bounds when a new shared state
(and therefore potential new Overlay) is set.

BUG=728802
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[tguilbert, 2017-06-01 21:49:36]

tguilbert@chromium.org changed reviewers:
+ liberato@chromium.org

[tguilbert, 2017-06-01 21:49:37]

PTAL!

[liberato (no reviews please), 2017-06-01 21:54:29]

lgtm

[tguilbert, 2017-06-01 21:57:52]

The CQ bit was checked by tguilbert@chromium.org

[commit-bot: I haz the power, 2017-06-01 21:59:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 22:30:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 22:30:58]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[tguilbert, 2017-06-01 23:07:11]

The CQ bit was checked by tguilbert@chromium.org

[tguilbert, 2017-06-01 23:07:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
liberato@chromium.org
Link to the patchset: https://codereview.chromium.org/2916193002/#ps20001
(title: "Typo")

[commit-bot: I haz the power, 2017-06-01 23:08:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 02:18:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496358431173790,
"parent_rev": "30d6d64a9b914d1e4b1584cf62b9e64adc20de9d", "commit_rev":
"d1fdad9d1437cad3bcdc373c02fbc10f7704252e"}

[commit-bot: I haz the power, 2017-06-02 02:18:28]

Description was changed from

==========
Reset |most_recent_bounds_| on new Overlay

When overlays are enabled, on Nexus 5 devices, upon exiting and
re-entering fullscreen, nothing is displayed on screen.

This is caused by the fact that AVDACodecImage never resets
|most_recent_bounds_| when a new overlay is received. This means
AndroidOverlay::ScheduleLayout() is never called in
AVDACodecImage::ScheduleOverlayPlane(), and new overlays retains their
initial bounds of [0,0,1,1].

This CL fixes the issue by reseting the bounds when a new shared state
(and therefore potential new Overlay) is set.

BUG=728802
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Reset |most_recent_bounds_| on new Overlay

When overlays are enabled, on Nexus 5 devices, upon exiting and
re-entering fullscreen, nothing is displayed on screen.

This is caused by the fact that AVDACodecImage never resets
|most_recent_bounds_| when a new overlay is received. This means
AndroidOverlay::ScheduleLayout() is never called in
AVDACodecImage::ScheduleOverlayPlane(), and new overlays retains their
initial bounds of [0,0,1,1].

This CL fixes the issue by reseting the bounds when a new shared state
(and therefore potential new Overlay) is set.

BUG=728802
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2916193002
Cr-Commit-Position: refs/heads/master@{#476524}
Committed:
https://chromium.googlesource.com/chromium/src/+/d1fdad9d1437cad3bcdc373c02fb...
==========

[commit-bot: I haz the power, 2017-06-02 02:18:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d1fdad9d1437cad3bcdc373c02fb...