Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2916073002: Implement PasswordStore::GetLoginsForSameOrganizationName. (Closed)

Created:
3 years, 6 months ago by engedy
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Implement PasswordStore::GetLoginsForSameOrganizationName. The method returns all stored credentials with SCHEME_HTTP that have an origin whose organization-identifying name -- that is, the first domain name label below the effective TLD -- matches that of a given origin. For example, the organization-identifying name of "https://foo.example.org" is `example`, and logins will be returned for "http://bar.example.co.uk", but not for "http://notexample.com" or "https://example.foo.com". BUG=720599 Review-Url: https://codereview.chromium.org/2899083004 Cr-Original-Commit-Position: refs/heads/master@{#475322} Review-Url: https://codereview.chromium.org/2916073002 . Cr-Commit-Position: refs/branch-heads/3112@{#84} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/517d0c7a0232d747b6a71f753cfb4c6274549049

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+505 lines, -18 lines) Patch
M chrome/browser/password_manager/password_store_mac.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/password_store_mac.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/password_store_proxy_mac.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/password_store_proxy_mac.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/password_store_x.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/password_store_x.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/login_database.h View 2 chunks +13 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/login_database.cc View 3 chunks +49 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/login_database_unittest.cc View 2 chunks +141 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/mock_password_store.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_store.h View 3 chunks +25 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_store.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_store_default.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_store_default.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_store_unittest.cc View 2 chunks +81 lines, -18 lines 0 comments Download
M components/password_manager/core/browser/psl_matching_helper.h View 1 chunk +5 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/psl_matching_helper.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/psl_matching_helper_unittest.cc View 2 chunks +101 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/test_password_store.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/test_password_store.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
engedy
3 years, 6 months ago (2017-06-01 12:33:13 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
517d0c7a0232d747b6a71f753cfb4c6274549049.

Powered by Google App Engine
This is Rietveld 408576698