[turbofan] Optimize Function.prototype.bind for the common case.

[turbofan] Optimize Function.prototype.bind for the common case.

When the input to Function.prototype.bind is a known function, we can
inline the allocation of the JSBoundFunction into TurboFan, which
provides a 2x speed-up for several hot functions in Node streams (as
discovered by Matteo Collina). One of example of this can be found in
https://github.com/nodejs/node/pull/13322, which can be optimized and
made more readable using bind instead of closures.

R=jarin@chromium.org

Review-Url: https://codereview.chromium.org/2916063002
Cr-Commit-Position: refs/heads/master@{#45679}
Committed: https://chromium.googlesource.com/v8/v8/+/3028f8075ec713d99ee4c5f419c7403cca14b446

[Benedikt Meurer, 2017-06-01 12:02:46]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 12:02:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2017-06-01 12:03:46]

Hey Jaro,

Here's something that Matteo pointed me too, where bind optimizations can help
to significantly reduce the number of hacks on the Node side to achieve decent
performance.

Please take a look.

Thanks,
Benedikt

[commit-bot: I haz the power, 2017-06-01 12:31:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 12:31:11]

Dry run: This issue passed the CQ dry run.

[Jarin, 2017-06-02 08:07:42]

lgtm

https://codereview.chromium.org/2916063002/diff/1/src/compiler/js-builtin-red...
File src/compiler/js-builtin-reducer.cc (right):

https://codereview.chromium.org/2916063002/diff/1/src/compiler/js-builtin-red...
src/compiler/js-builtin-reducer.cc:1261: : NodeProperties::GetValueInput(node,
2);
Please describe in a comment what is the layout of inputs here.

[Benedikt Meurer, 2017-06-02 11:57:04]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 11:57:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2017-06-02 11:58:43]

https://codereview.chromium.org/2916063002/diff/1/src/compiler/js-builtin-red...
File src/compiler/js-builtin-reducer.cc (right):

https://codereview.chromium.org/2916063002/diff/1/src/compiler/js-builtin-red...
src/compiler/js-builtin-reducer.cc:1261: : NodeProperties::GetValueInput(node,
2);
On 2017/06/02 08:07:42, Jarin wrote:
> Please describe in a comment what is the layout of inputs here.

Done.

[Benedikt Meurer, 2017-06-02 11:58:48]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2017-06-02 11:58:50]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2017-06-02 11:58:50]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2916063002/#ps20001
(title: "Address feedback.")

[commit-bot: I haz the power, 2017-06-02 11:58:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 12:30:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496404730368860,
"parent_rev": "1e813e5341ec74413ff52bce02788e499b994a72", "commit_rev":
"3028f8075ec713d99ee4c5f419c7403cca14b446"}

[commit-bot: I haz the power, 2017-06-02 12:30:11]

Description was changed from

==========
[turbofan] Optimize Function.prototype.bind for the common case.

When the input to Function.prototype.bind is a known function, we can
inline the allocation of the JSBoundFunction into TurboFan, which
provides a 2x speed-up for several hot functions in Node streams (as
discovered by Matteo Collina). One of example of this can be found in
https://github.com/nodejs/node/pull/13322, which can be optimized and
made more readable using bind instead of closures.

R=jarin@chromium.org
==========

to

==========
[turbofan] Optimize Function.prototype.bind for the common case.

When the input to Function.prototype.bind is a known function, we can
inline the allocation of the JSBoundFunction into TurboFan, which
provides a 2x speed-up for several hot functions in Node streams (as
discovered by Matteo Collina). One of example of this can be found in
https://github.com/nodejs/node/pull/13322, which can be optimized and
made more readable using bind instead of closures.

R=jarin@chromium.org

Review-Url: https://codereview.chromium.org/2916063002
Cr-Commit-Position: refs/heads/master@{#45679}
Committed:
https://chromium.googlesource.com/v8/v8/+/3028f8075ec713d99ee4c5f419c7403cca1...
==========

[commit-bot: I haz the power, 2017-06-02 12:30:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/3028f8075ec713d99ee4c5f419c7403cca1...