[CRD iOS] Fix shadow between host cards and use anchor constraints

[CRD iOS] Fix shadow between host cards and use anchor constraints

This CL fixes these issues in the host list UX:
1. Fixes the mysterious shadow occasionally showed between host cards.
2. Fixes the constraint of the label's width.
3. Use anchor constraints to minimize position calculations and use leading &
   trailing anchors to better support RTL languages.

BUG=728280
Review-Url: https://codereview.chromium.org/2916003002
Cr-Commit-Position: refs/heads/master@{#476381}
Committed: https://chromium.googlesource.com/chromium/src/+/625e0f8156b02d6dd9544d86defcd0f6665ecae9

[Yuwei, 2017-06-01 02:14:15]

Patchset #2 (id:20001) has been deleted

[Yuwei, 2017-06-01 02:14:18]

Patchset #1 (id:1) has been deleted

[Yuwei, 2017-06-01 04:18:26]

Description was changed from

==========
[CRD iOS] Fix shadow between host cards and use anchor constraints

BUG=
==========

to

==========
[CRD iOS] Fix shadow between host cards and use anchor constraints

This CL fixes these issues in the host list UX:
1. Fixes the mysterious shadow occasionally showed between host cards.
2. Fixes the constraint of the label's width.
3. Use anchor constraints to minimize position calculations and use leading &
   trailing anchors to better support RTL languages.

BUG=728280
==========

[Yuwei, 2017-06-01 04:27:17]

yuweih@chromium.org changed reviewers:
+ nicholss@chromium.org

[Yuwei, 2017-06-01 04:27:17]

PTAL thanks!

I guess this class was originally copied from the Pesto demo? :P

https://codereview.chromium.org/2916003002/diff/40001/remoting/ios/app/host_c...
File remoting/ios/app/host_collection_view_cell.mm (left):

https://codereview.chromium.org/2916003002/diff/40001/remoting/ios/app/host_c...
remoting/ios/app/host_collection_view_cell.mm:41: return [MDCShadowLayer class];
The collection view by default has its own separator style and a lighter shadow
so it's not necessary o override the shadow layer here. This shadow layer
occasionally overlays on another cell.

https://codereview.chromium.org/2916003002/diff/40001/remoting/ios/app/host_c...
remoting/ios/app/host_collection_view_cell.mm:57: _cellView.backgroundColor =
[UIColor whiteColor];
Changing the background color will weirdly hide the default separator...

https://codereview.chromium.org/2916003002/diff/40001/remoting/ios/app/host_c...
File remoting/ios/app/host_collection_view_cell.mm (right):

https://codereview.chromium.org/2916003002/diff/40001/remoting/ios/app/host_c...
remoting/ios/app/host_collection_view_cell.mm:49: _cellView = [[UIView alloc]
init];
Looks like we don't need the extra cellView in our case. Let's remove it to
simplify some code?

https://codereview.chromium.org/2916003002/diff/40001/remoting/ios/app/host_c...
remoting/ios/app/host_collection_view_cell.mm:85: [[_cellView leadingAnchor]
constraintEqualToAnchor:[self leadingAnchor]],
FYI leading and trailing are left and right in LTR language but will become
right and left in RTL language

[nicholss, 2017-06-01 17:31:08]

lgtm

[Yuwei, 2017-06-01 18:56:32]

Thanks!

https://codereview.chromium.org/2916003002/diff/40001/remoting/ios/app/host_c...
File remoting/ios/app/host_collection_view_cell.mm (right):

https://codereview.chromium.org/2916003002/diff/40001/remoting/ios/app/host_c...
remoting/ios/app/host_collection_view_cell.mm:49: _cellView = [[UIView alloc]
init];
On 2017/06/01 04:27:17, Yuwei wrote:
> Looks like we don't need the extra cellView in our case. Let's remove it to
> simplify some code?

Done.

[Yuwei, 2017-06-01 18:56:57]

The CQ bit was checked by yuweih@chromium.org

[Yuwei, 2017-06-01 18:56:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
nicholss@chromium.org
Link to the patchset: https://codereview.chromium.org/2916003002/#ps60001
(title: "Use self.contentView and add ASCII art")

[commit-bot: I haz the power, 2017-06-01 18:57:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 19:14:35]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496343417164920,
"parent_rev": "d4b5948ed8ff5d9b99b876998a5835ffc6ff42c8", "commit_rev":
"625e0f8156b02d6dd9544d86defcd0f6665ecae9"}

[commit-bot: I haz the power, 2017-06-01 19:14:51]

Description was changed from

==========
[CRD iOS] Fix shadow between host cards and use anchor constraints

This CL fixes these issues in the host list UX:
1. Fixes the mysterious shadow occasionally showed between host cards.
2. Fixes the constraint of the label's width.
3. Use anchor constraints to minimize position calculations and use leading &
   trailing anchors to better support RTL languages.

BUG=728280
==========

to

==========
[CRD iOS] Fix shadow between host cards and use anchor constraints

This CL fixes these issues in the host list UX:
1. Fixes the mysterious shadow occasionally showed between host cards.
2. Fixes the constraint of the label's width.
3. Use anchor constraints to minimize position calculations and use leading &
   trailing anchors to better support RTL languages.

BUG=728280

Review-Url: https://codereview.chromium.org/2916003002
Cr-Commit-Position: refs/heads/master@{#476381}
Committed:
https://chromium.googlesource.com/chromium/src/+/625e0f8156b02d6dd9544d86defc...
==========

[commit-bot: I haz the power, 2017-06-01 19:14:53]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/625e0f8156b02d6dd9544d86defc...