Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2915963002: [Merge M60] arg: Support non-standard display scale factors. (Closed)

Created:
3 years, 6 months ago by khmel
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

[Merge M60] arg: Support non-standard display scale factors. This CL makes it possible to use ARC app icons in notification view, ARC uninstall dialog view and other places. TEST=Unit test + manually on device. BUG=725927 BUG=b/36790645 BUG=b/34521325 TBR=xiyuan@chromium.org,oshima@chromium.org,msw@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2902153002 Cr-Original-Commit-Position: refs/heads/master@{#475185} Review-Url: https://codereview.chromium.org/2915963002 Cr-Commit-Position: refs/branch-heads/3112@{#74} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/3526ec26b275d2249dc7f381c528dc548ce71d2b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -28 lines) Patch
M chrome/browser/ui/app_list/arc/arc_app_icon.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_icon.cc View 2 chunks +8 lines, -14 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_unittest.cc View 2 chunks +76 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/image_skia.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gfx/image/image_skia.cc View 3 chunks +21 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2915963002/1
3 years, 6 months ago (2017-06-01 00:21:47 UTC) #4
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 00:22:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3526ec26b275d2249dc7f381c528...

Powered by Google App Engine
This is Rietveld 408576698