Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Issue 2915943002: kiosk: Skip LOGGED_IN_NOT_ACTIVE during app launch (Closed)

Created:
3 years, 6 months ago by xiyuan
Modified:
3 years, 6 months ago
Reviewers:
tbarzic
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

kiosk: Skip LOGGED_IN_NOT_ACTIVE during app launch Ash is changed that LOGGED_IN_NOT_ACTIVE is treated as a non user blocking state so that browser windows during user sign-in are can be activated before login screen is dismissed. However a side effect of that is modal dialog under this state will be placed in SystemModalContainer instead of LockSystemModalContainer and causing the issue. The CL skips LOGGED_IN_NOT_ACTIVE during app launch so that dialogs created during the app launch are placed to the correct container. BUG=727951 Review-Url: https://codereview.chromium.org/2915943002 Cr-Commit-Position: refs/heads/master@{#476327} Committed: https://chromium.googlesource.com/chromium/src/+/aba83971264e7cdb32577693ef7f28953af5d2e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
xiyuan
It is a band-aid for the kiosk regression. The requirements are conflicting with each other ...
3 years, 6 months ago (2017-06-01 15:35:22 UTC) #6
tbarzic
lgtm
3 years, 6 months ago (2017-06-01 16:31:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2915943002/1
3 years, 6 months ago (2017-06-01 16:51:36 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 16:57:13 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aba83971264e7cdb32577693ef7f...

Powered by Google App Engine
This is Rietveld 408576698