Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_invalid_type_builder.dart

Issue 2915933004: Clean up handling of types. (Closed)
Patch Set: Merged with 586a465c45db7d1ec7498b8c1df9cc8d245e8e61. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart ('k') | tests/co19/co19-kernel.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/kernel/kernel_invalid_type_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_invalid_type_builder.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_invalid_type_builder.dart
index 7b39b369afe269b77dcd0f8b230649bc8faf7ea1..3a434fcf526c37905af69dce705e90b81fad5af8 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_invalid_type_builder.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_invalid_type_builder.dart
@@ -4,30 +4,29 @@
library fasta.kernel_invalid_type_builder;
-import 'package:kernel/ast.dart' show DartType, DynamicType;
-
-import '../messages.dart' show warning;
+import 'package:kernel/ast.dart' show DartType, InvalidType;
import 'kernel_builder.dart'
show InvalidTypeBuilder, KernelTypeBuilder, LibraryBuilder;
class KernelInvalidTypeBuilder
extends InvalidTypeBuilder<KernelTypeBuilder, DartType> {
- KernelInvalidTypeBuilder(String name, int charOffset, Uri fileUri)
- : super(name, charOffset, fileUri);
+ final String message;
+
+ KernelInvalidTypeBuilder(String name, int charOffset, Uri fileUri,
+ [String message])
+ : message = message ?? "No type for: '$name'.",
+ super(name, charOffset, fileUri);
DartType buildType(
LibraryBuilder library, List<KernelTypeBuilder> arguments) {
- // TODO(ahe): Implement error handling.
- warning(fileUri, charOffset, "No type for: '$name'.");
- return const DynamicType();
+ return buildTypesWithBuiltArguments(library, null);
}
/// [Arguments] have already been built.
DartType buildTypesWithBuiltArguments(
LibraryBuilder library, List<DartType> arguments) {
- // TODO(ahe): Implement error handling.
- warning(fileUri, charOffset, "No type for: '$name'.");
- return const DynamicType();
+ library.addWarning(charOffset, message, fileUri: fileUri);
+ return const InvalidType();
}
}
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart ('k') | tests/co19/co19-kernel.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698