Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_manager.cc

Issue 2915913002: [WebAPKs] Display same text for menu & engagement banner (Closed)
Patch Set: Merge branch 'master' into same_infobar_title Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapps/add_to_homescreen_manager.cc
diff --git a/chrome/browser/android/webapps/add_to_homescreen_manager.cc b/chrome/browser/android/webapps/add_to_homescreen_manager.cc
index f5e8ecd5d1d356a2a1960bf2153a6acfbfac0b65..e908c6f3d748fcd384de9991718fcf77d7b4c712 100644
--- a/chrome/browser/android/webapps/add_to_homescreen_manager.cc
+++ b/chrome/browser/android/webapps/add_to_homescreen_manager.cc
@@ -66,13 +66,11 @@ void AddToHomescreenManager::AddShortcut(
base::string16 user_title =
base::android::ConvertJavaStringToUTF16(env, j_user_title);
- if (!user_title.empty())
- data_fetcher_->shortcut_info().user_title = user_title;
RecordAddToHomescreen();
- ShortcutHelper::AddToLauncherWithSkBitmap(web_contents,
- data_fetcher_->shortcut_info(),
- data_fetcher_->primary_icon());
+ ShortcutHelper::AddToLauncherWithSkBitmap(
+ web_contents, data_fetcher_->shortcut_info(), user_title,
+ data_fetcher_->primary_icon());
// Fire the appinstalled event.
banners::AppBannerManagerAndroid* app_banner_manager =
@@ -176,7 +174,7 @@ void AddToHomescreenManager::CreateInfoBarForWebApk(
banners::AppBannerManagerAndroid* app_banner_manager =
banners::AppBannerManagerAndroid::FromWebContents(web_contents);
banners::AppBannerInfoBarDelegateAndroid::Create(
- web_contents, app_banner_manager->GetWeakPtr(), info.user_title,
+ web_contents, app_banner_manager->GetWeakPtr(),
base::MakeUnique<ShortcutInfo>(info), primary_icon, badge_icon,
-1 /* event_request_id */, true /* is_webapk */,
webapk::INSTALL_SOURCE_MENU);

Powered by Google App Engine
This is Rietveld 408576698