[WebAPKs] Display same text for menu & engagement banner

chrome/browser/android/webapps/add_to_homescreen_manager.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/webapps/add_to_homescreen_manager.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/location.h"
 #include "base/memory/ptr_util.h"
@@ skipping 48 matching lines @@
 void AddToHomescreenManager::AddShortcut(
     JNIEnv* env,
     const JavaParamRef<jobject>& obj,
     const JavaParamRef<jstring>& j_user_title) {
   content::WebContents* web_contents = data_fetcher_->web_contents();
   if (!web_contents)
     return;
 
   base::string16 user_title =
       base::android::ConvertJavaStringToUTF16(env, j_user_title);
-  if (!user_title.empty())
-    data_fetcher_->shortcut_info().user_title = user_title;
 
   RecordAddToHomescreen();
-  ShortcutHelper::AddToLauncherWithSkBitmap(web_contents,
-                                            data_fetcher_->shortcut_info(),
-                                            data_fetcher_->primary_icon());
+  ShortcutHelper::AddToLauncherWithSkBitmap(
+      web_contents, data_fetcher_->shortcut_info(), user_title,
+      data_fetcher_->primary_icon());
 
   // Fire the appinstalled event.
   banners::AppBannerManagerAndroid* app_banner_manager =
       banners::AppBannerManagerAndroid::FromWebContents(web_contents);
   app_banner_manager->OnInstall();
 }
 
 void AddToHomescreenManager::Start(content::WebContents* web_contents) {
   bool check_webapk_compatible = false;
   if (ChromeWebApkHost::CanInstallWebApk() &&
@@ skipping 83 matching lines @@
 }
 
 void AddToHomescreenManager::CreateInfoBarForWebApk(
     const ShortcutInfo& info,
     const SkBitmap& primary_icon,
     const SkBitmap& badge_icon) {
   content::WebContents* web_contents = data_fetcher_->web_contents();
   banners::AppBannerManagerAndroid* app_banner_manager =
       banners::AppBannerManagerAndroid::FromWebContents(web_contents);
   banners::AppBannerInfoBarDelegateAndroid::Create(
-      web_contents, app_banner_manager->GetWeakPtr(), info.user_title,
+      web_contents, app_banner_manager->GetWeakPtr(),
       base::MakeUnique<ShortcutInfo>(info), primary_icon, badge_icon,
       -1 /* event_request_id */, true /* is_webapk */,
       webapk::INSTALL_SOURCE_MENU);
 }
 
 SkBitmap AddToHomescreenManager::FinalizeLauncherIconInBackground(
     const SkBitmap& bitmap,
     const GURL& url,
     bool* is_generated) {
   base::ThreadRestrictions::AssertIOAllowed();
 
   return ShortcutHelper::FinalizeLauncherIconInBackground(bitmap, url,
                                                           is_generated);
 }