Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 2915903002: WebUI: Fix dialog showing unnecessary scrollbars (Closed)

Created:
3 years, 6 months ago by scottchen
Modified:
3 years, 6 months ago
Reviewers:
dpapad
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI: Fix dialog showing unnecessary scrollbars BUG=727190 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2915903002 Cr-Commit-Position: refs/heads/master@{#476105} Committed: https://chromium.googlesource.com/chromium/src/+/0da880a492cedc5c7a612180e84cd5527ae2f0b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
scottchen
3 years, 6 months ago (2017-05-31 20:57:03 UTC) #3
dpapad
LGTM (tried this locally on Linux). FWIW, the original CL worked fine on Mac, but ...
3 years, 6 months ago (2017-05-31 21:06:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2915903002/1
3 years, 6 months ago (2017-05-31 21:28:42 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 00:13:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0da880a492cedc5c7a612180e84c...

Powered by Google App Engine
This is Rietveld 408576698