third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js - Issue 2915883002: DevTools: prepare to unify Network and CPU throttling UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 2915883002: DevTools: prepare to unify Network and CPU throttling UI (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/network_conditions/module.json ('K') | « third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/module.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

index 3dcbdab9f2acd1dcc15816219a4e3514fadcef85..7c2df76bfcf4c79be040acb7677d618b29ef2392 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

@@ -827,7 +827,7 @@ Timeline.TimelineUIUtils = class {

if (eventData['mimeType'])

contentHelper.appendTextRow(Common.UIString('MIME Type'), eventData['mimeType']);

if ('priority' in eventData) {

- var priority = NetworkConditions.uiLabelForPriority(eventData['priority']);

+ var priority = MobileThrottling.uiLabelForPriority(eventData['priority']);

contentHelper.appendTextRow(Common.UIString('Priority'), priority);

}

if (eventData['encodedDataLength']) {

@@ -1144,7 +1144,7 @@ Timeline.TimelineUIUtils = class {

contentHelper.appendTextRow(Common.UIString('Request Method'), request.requestMethod);

if (typeof request.priority === 'string') {

const priority =

- NetworkConditions.uiLabelForPriority(/** @type {!Protocol.Network.ResourcePriority} */ (request.priority));

+ MobileThrottling.uiLabelForPriority(/** @type {!Protocol.Network.ResourcePriority} */ (request.priority));

contentHelper.appendTextRow(Common.UIString('Priority'), priority);

}

if (request.mimeType)