Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: third_party/WebKit/Source/devtools/front_end/mobile_throttling/NetworkPriorities.js

Issue 2915883002: DevTools: prepare to unify Network and CPU throttling UI (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/mobile_throttling/NetworkPriorities.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkPriorities.js b/third_party/WebKit/Source/devtools/front_end/mobile_throttling/NetworkPriorities.js
similarity index 66%
rename from third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkPriorities.js
rename to third_party/WebKit/Source/devtools/front_end/mobile_throttling/NetworkPriorities.js
index 6f7a67021318ca9532fde217fa60d25598f36261..c868edc58ac2b36cc44bde9771c7817c6f8ff61d 100644
--- a/third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkPriorities.js
+++ b/third_party/WebKit/Source/devtools/front_end/mobile_throttling/NetworkPriorities.js
@@ -6,8 +6,8 @@
* @param {!Protocol.Network.ResourcePriority} priority
* @return {string}
*/
-NetworkConditions.uiLabelForPriority = function(priority) {
- var map = NetworkConditions.priorityUiLabelMap();
+MobileThrottling.uiLabelForPriority = function(priority) {
dgozman 2017/05/31 20:05:32 This one does not belong to MobileThrottling :-) L
chenwilliam 2017/05/31 22:23:12 You're right! I made it into a new module "network
+ var map = MobileThrottling.priorityUiLabelMap();
return map.get(priority) || '';
};
@@ -15,25 +15,25 @@ NetworkConditions.uiLabelForPriority = function(priority) {
* @param {string} priorityLabel
* @return {string}
*/
-NetworkConditions.uiLabelToPriority = function(priorityLabel) {
+MobileThrottling.uiLabelToPriority = function(priorityLabel) {
/** @type {!Map<string, !Protocol.Network.ResourcePriority>} */
- var labelToPriorityMap = NetworkConditions.uiLabelToPriority._uiLabelToPriorityMap;
+ var labelToPriorityMap = MobileThrottling.uiLabelToPriority._uiLabelToPriorityMap;
if (labelToPriorityMap)
return labelToPriorityMap.get(priorityLabel);
labelToPriorityMap = new Map();
- NetworkConditions.priorityUiLabelMap().forEach((value, key) => labelToPriorityMap.set(value, key));
- NetworkConditions.uiLabelToPriority._uiLabelToPriorityMap = labelToPriorityMap;
+ MobileThrottling.priorityUiLabelMap().forEach((value, key) => labelToPriorityMap.set(value, key));
+ MobileThrottling.uiLabelToPriority._uiLabelToPriorityMap = labelToPriorityMap;
return labelToPriorityMap.get(priorityLabel) || '';
};
/**
* @return {!Map<!Protocol.Network.ResourcePriority, string>}
*/
-NetworkConditions.priorityUiLabelMap = function() {
+MobileThrottling.priorityUiLabelMap = function() {
/** @type {!Map<!Protocol.Network.ResourcePriority, string>} */
- var map = NetworkConditions.priorityUiLabelMap._priorityUiLabelMap;
+ var map = MobileThrottling.priorityUiLabelMap._priorityUiLabelMap;
if (map)
return map;
@@ -44,7 +44,7 @@ NetworkConditions.priorityUiLabelMap = function() {
map.set(Protocol.Network.ResourcePriority.Medium, Common.UIString('Medium'));
map.set(Protocol.Network.ResourcePriority.High, Common.UIString('High'));
map.set(Protocol.Network.ResourcePriority.VeryHigh, Common.UIString('Highest'));
- NetworkConditions.priorityUiLabelMap._priorityUiLabelMap = map;
+ MobileThrottling.priorityUiLabelMap._priorityUiLabelMap = map;
return map;
};
@@ -52,9 +52,9 @@ NetworkConditions.priorityUiLabelMap = function() {
/**
* @return {!Map<!Protocol.Network.ResourcePriority, number>}
*/
-NetworkConditions.prioritySymbolToNumericMap = function() {
+MobileThrottling.prioritySymbolToNumericMap = function() {
/** @type {!Map<!Protocol.Network.ResourcePriority, number>} */
- var priorityMap = NetworkConditions.prioritySymbolToNumericMap._symbolicToNumericPriorityMap;
+ var priorityMap = MobileThrottling.prioritySymbolToNumericMap._symbolicToNumericPriorityMap;
if (priorityMap)
return priorityMap;
@@ -65,7 +65,7 @@ NetworkConditions.prioritySymbolToNumericMap = function() {
priorityMap.set(Protocol.Network.ResourcePriority.Medium, 3);
priorityMap.set(Protocol.Network.ResourcePriority.High, 4);
priorityMap.set(Protocol.Network.ResourcePriority.VeryHigh, 5);
- NetworkConditions.prioritySymbolToNumericMap._symbolicToNumericPriorityMap = priorityMap;
+ MobileThrottling.prioritySymbolToNumericMap._symbolicToNumericPriorityMap = priorityMap;
return priorityMap;
};

Powered by Google App Engine
This is Rietveld 408576698