Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: chromeos/components/tether/host_scan_cache_unittest.cc

Issue 2915833003: Tether: Break helper TimerFactory out of BleConnectionManager and HostScanCache. (Closed)
Patch Set: Add missing files. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/components/tether/host_scan_cache_unittest.cc
diff --git a/chromeos/components/tether/host_scan_cache_unittest.cc b/chromeos/components/tether/host_scan_cache_unittest.cc
index b082e59c67a677dbc40a065388699b1c44546d73..bb77979199ad2bd521ea2b3f0628fa4cdda8d672 100644
--- a/chromeos/components/tether/host_scan_cache_unittest.cc
+++ b/chromeos/components/tether/host_scan_cache_unittest.cc
@@ -16,6 +16,7 @@
#include "chromeos/components/tether/fake_active_host.h"
#include "chromeos/components/tether/fake_host_scan_cache.h"
#include "chromeos/components/tether/mock_tether_host_response_recorder.h"
+#include "chromeos/components/tether/timer_factory.h"
#include "chromeos/dbus/dbus_thread_manager.h"
#include "chromeos/network/network_state.h"
#include "chromeos/network/network_state_handler.h"
@@ -78,10 +79,10 @@ class ExtendedMockTimer : public base::MockTimer {
// if possible.
class HostScanCacheTest : public NetworkStateTest {
protected:
- class TestTimerFactory : public HostScanCache::TimerFactory {
+ class TestTimerFactory : public TimerFactory {
khorimoto 2017/05/31 18:13:28 Move to anonymous namespace.
Ryan Hansberry 2017/05/31 18:24:54 Done.
public:
TestTimerFactory() {}
- ~TestTimerFactory() {}
+ ~TestTimerFactory() override {}
std::unordered_map<std::string, ExtendedMockTimer*>&
tether_network_guid_to_timer_map() {
@@ -93,7 +94,7 @@ class HostScanCacheTest : public NetworkStateTest {
tether_network_guid_for_next_timer_ = tether_network_guid_for_next_timer;
}
- // HostScanCache::TimerFactory:
+ // TimerFactory:
std::unique_ptr<base::Timer> CreateOneShotTimer() override {
EXPECT_FALSE(tether_network_guid_for_next_timer_.empty());
ExtendedMockTimer* mock_timer = new ExtendedMockTimer(base::Bind(

Powered by Google App Engine
This is Rietveld 408576698