Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Issue 291583006: Remove WEBCRYPTO_HMAC_KEY_HAS_LENGTH. (Closed)

Created:
6 years, 7 months ago by jbroman
Modified:
6 years, 7 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

Remove WEBCRYPTO_HMAC_KEY_HAS_LENGTH. This is no longer needed since >1 month ago: https://codereview.chromium.org/205583003 BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174495

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M public/platform/WebCryptoKeyAlgorithmParams.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jbroman
It looks like this simply got forgotten.
6 years, 7 months ago (2014-05-16 23:55:30 UTC) #1
eroman
lgtm
6 years, 7 months ago (2014-05-16 23:58:27 UTC) #2
jbroman
On 2014/05/16 23:58:27, eroman wrote: > lgtm +jochen for public/ OWNERS (abarth is OOO)
6 years, 7 months ago (2014-05-20 22:06:00 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 7 months ago (2014-05-21 08:47:54 UTC) #4
jbroman
The CQ bit was checked by jbroman@chromium.org
6 years, 7 months ago (2014-05-21 13:39:24 UTC) #5
jbroman
The CQ bit was unchecked by jbroman@chromium.org
6 years, 7 months ago (2014-05-21 14:28:58 UTC) #6
jbroman
The CQ bit was checked by jbroman@chromium.org
6 years, 7 months ago (2014-05-21 14:28:58 UTC) #7
jbroman
The CQ bit was unchecked by jbroman@chromium.org
6 years, 7 months ago (2014-05-21 14:28:59 UTC) #8
jbroman
The CQ bit was checked by jbroman@chromium.org
6 years, 7 months ago (2014-05-21 14:29:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/291583006/1
6 years, 7 months ago (2014-05-21 17:51:09 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 23:59:02 UTC) #11
Message was sent while issue was closed.
Change committed as 174495

Powered by Google App Engine
This is Rietveld 408576698