Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 205583003: [webcrypto] Remove ifdefs for whether hmac key algorithm has length. (Closed)

Created:
6 years, 9 months ago by eroman
Modified:
6 years, 9 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

[webcrypto] Remove ifdefs for whether hmac key algorithm has length. BUG=245025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258413

Patch Set 1 #

Patch Set 2 : fix indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -21 lines) Patch
M content/child/webcrypto/shared_crypto_unittest.cc View 1 6 chunks +3 lines, -15 lines 0 comments Download
M content/child/webcrypto/webcrypto_util.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
eroman
to be committed once blink rolls
6 years, 9 months ago (2014-03-19 23:40:54 UTC) #1
Ryan Sleevi
lgtm
6 years, 9 months ago (2014-03-20 00:58:02 UTC) #2
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 9 months ago (2014-03-20 18:03:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/205583003/20001
6 years, 9 months ago (2014-03-20 18:04:29 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 18:11:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-20 18:11:18 UTC) #6
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 9 months ago (2014-03-20 18:15:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/205583003/20001
6 years, 9 months ago (2014-03-20 18:19:46 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 21:33:14 UTC) #9
Message was sent while issue was closed. 
Change committed as 258413

Powered by Google App Engine
This is Rietveld 408576698