Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: components/autofill/content/common/autofill_driver.mojom

Issue 2915763003: [Password Manager] Show omnibox icon and anchored prompt once user start typing password (Closed)
Patch Set: Sent For Review Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/common/autofill_driver.mojom
diff --git a/components/autofill/content/common/autofill_driver.mojom b/components/autofill/content/common/autofill_driver.mojom
index 46e7977773036e5a2c96435471337285e1ed8e58..490a5ee057d0d83525dd96c5c98dab7379839c92 100644
--- a/components/autofill/content/common/autofill_driver.mojom
+++ b/components/autofill/content/common/autofill_driver.mojom
@@ -77,6 +77,14 @@ interface PasswordManagerDriver {
// Notification that this password form was submitted by the user.
PasswordFormSubmitted(PasswordForm password_form);
+
+ // Notification that the omnibox icon with anchored save/update prompt should
+ // be available.
vasilii 2017/07/21 12:48:20 Can we get a bit lower level here. Describe what t
kolos1 2017/07/24 15:33:30 Done.
+ ShowManualFallback(PasswordForm password_form);
vasilii 2017/07/21 12:48:20 Emphasize that it's for saving. Same below.
kolos1 2017/07/24 15:33:30 Done.
+
+ // Notification that the save/update prompt anchored to the omnibox icon
+ // should be removed.
+ HideManualFallback();
// Notification that in-page navigation happened and at this moment we have
// filled password form. We use this as a signal for successful login.

Powered by Google App Engine
This is Rietveld 408576698