Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: components/autofill/content/common/autofill_driver.mojom

Issue 2915763003: [Password Manager] Show omnibox icon and anchored prompt once user start typing password (Closed)
Patch Set: Sent For Review Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 module autofill.mojom; 5 module autofill.mojom;
6 6
7 import "components/autofill/content/common/autofill_types.mojom"; 7 import "components/autofill/content/common/autofill_types.mojom";
8 import "mojo/common/string16.mojom"; 8 import "mojo/common/string16.mojom";
9 import "mojo/common/text_direction.mojom"; 9 import "mojo/common/text_direction.mojom";
10 import "mojo/common/time.mojom"; 10 import "mojo/common/time.mojom";
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 PasswordFormsParsed(array<PasswordForm> forms); 70 PasswordFormsParsed(array<PasswordForm> forms);
71 71
72 // Notification that initial layout has occurred and the following password 72 // Notification that initial layout has occurred and the following password
73 // forms are visible on the page (e.g. not set to display:none.), and whether 73 // forms are visible on the page (e.g. not set to display:none.), and whether
74 // all frames in the page have been rendered. 74 // all frames in the page have been rendered.
75 PasswordFormsRendered(array<PasswordForm> visible_forms, 75 PasswordFormsRendered(array<PasswordForm> visible_forms,
76 bool did_stop_loading); 76 bool did_stop_loading);
77 77
78 // Notification that this password form was submitted by the user. 78 // Notification that this password form was submitted by the user.
79 PasswordFormSubmitted(PasswordForm password_form); 79 PasswordFormSubmitted(PasswordForm password_form);
80
81 // Notification that the omnibox icon with anchored save/update prompt should
82 // be available.
vasilii 2017/07/21 12:48:20 Can we get a bit lower level here. Describe what t
kolos1 2017/07/24 15:33:30 Done.
83 ShowManualFallback(PasswordForm password_form);
vasilii 2017/07/21 12:48:20 Emphasize that it's for saving. Same below.
kolos1 2017/07/24 15:33:30 Done.
84
85 // Notification that the save/update prompt anchored to the omnibox icon
86 // should be removed.
87 HideManualFallback();
80 88
81 // Notification that in-page navigation happened and at this moment we have 89 // Notification that in-page navigation happened and at this moment we have
82 // filled password form. We use this as a signal for successful login. 90 // filled password form. We use this as a signal for successful login.
83 InPageNavigation(PasswordForm password_form); 91 InPageNavigation(PasswordForm password_form);
84 92
85 // Sends |log| to browser for displaying to the user. Only strings passed as 93 // Sends |log| to browser for displaying to the user. Only strings passed as
86 // an argument to methods overriding SavePasswordProgressLogger::SendLog may 94 // an argument to methods overriding SavePasswordProgressLogger::SendLog may
87 // become |log|, because those are guaranteed to be sanitized. 95 // become |log|, because those are guaranteed to be sanitized.
88 // Never pass a free-form string as |log|. 96 // Never pass a free-form string as |log|.
89 RecordSavePasswordProgress(string log); 97 RecordSavePasswordProgress(string log);
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 PasswordForm password_form); 154 PasswordForm password_form);
147 155
148 // Instructs the browser to show the popup for editing a generated password. 156 // Instructs the browser to show the popup for editing a generated password.
149 // The location should be specified in the renderers coordinate system. Form 157 // The location should be specified in the renderers coordinate system. Form
150 // is the form associated with the password field. 158 // is the form associated with the password field.
151 ShowPasswordEditingPopup(gfx.mojom.RectF bounds, PasswordForm password_form); 159 ShowPasswordEditingPopup(gfx.mojom.RectF bounds, PasswordForm password_form);
152 160
153 // Instructs the browser to hide any password generation popups. 161 // Instructs the browser to hide any password generation popups.
154 HidePasswordGenerationPopup(); 162 HidePasswordGenerationPopup();
155 }; 163 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698