Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2389)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 2915763003: [Password Manager] Show omnibox icon and anchored prompt once user start typing password (Closed)
Patch Set: Sent For Review Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index 5e479c2d70c6f689eb92f9dbad2792bc0a378b44..766996ab17678210478a8fd849c5539ebe27b1ed 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -296,6 +296,31 @@ bool ChromePasswordManagerClient::PromptUserToSaveOrUpdatePassword(
return true;
}
+void ChromePasswordManagerClient::ShowManualFallback(
+ std::unique_ptr<password_manager::PasswordFormManager> form_to_save,
+ bool is_update) {
+ if (!CanShowBubbleOnURL(web_contents()->GetLastCommittedURL()))
+ return;
+
+#if !defined(OS_ANDROID)
+ PasswordsClientUIDelegate* manage_passwords_ui_controller =
+ PasswordsClientUIDelegateFromWebContents(web_contents());
+ manage_passwords_ui_controller->OnShowManualFallback(std::move(form_to_save),
+ is_update);
+#endif // !defined(OS_ANDROID)
+}
+
+void ChromePasswordManagerClient::HideManualFallback() {
+ if (!CanShowBubbleOnURL(web_contents()->GetLastCommittedURL()))
+ return;
+
+#if !defined(OS_ANDROID)
+ PasswordsClientUIDelegate* manage_passwords_ui_controller =
+ PasswordsClientUIDelegateFromWebContents(web_contents());
+ manage_passwords_ui_controller->OnHideManualFallback();
+#endif // !defined(OS_ANDROID)
+}
+
bool ChromePasswordManagerClient::PromptUserToChooseCredentials(
std::vector<std::unique_ptr<autofill::PasswordForm>> local_forms,
const GURL& origin,

Powered by Google App Engine
This is Rietveld 408576698