[Password Manager] Show omnibox icon and anchored prompt once user start typing password

chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
index 6ef8efa9463e80cf8cc80a17696e21889dadbcb4..97a832d0a66cee8f40741cfa929b1c795e0e97ba 100644
--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
@@ -94,6 +94,31 @@ void ManagePasswordsUIController::OnUpdatePasswordSubmitted(
   UpdateBubbleAndIconVisibility();
 }
 
+void ManagePasswordsUIController::OnShowManualFallback(
+    std::unique_ptr<PasswordFormManager> form_manager,
+    bool is_update) {
+  DestroyAccountChooser();
+  if (form_manager->has_generated_password())
+    passwords_data_.OnAutomaticPasswordSave(std::move(form_manager));

[vasilii, 2017/07/21 12:48:19]

That I don't understand. What scenario do you keep in mind and why is UI
confused with OnShowManualFallback in that case?

[kolos1, 2017/07/24 15:33:29]

If a user accepts a generated password, the icon appears in the omnibox and the
confirmation bubble is anchored to that icon.

[vasilii, 2017/07/25 11:17:46]

That password is saved automatically and the confirmation bubble has a very
little value because there is no option to view/edit anything.
We discussed on the meeting briefly that for now it's fine if we don't provide
manual fallbacks for the generation case because the user will have the correct
password saved anyway. Thus, I think we shouldn't call this function at all. Of
course the icon may appear for manual fallback on another form on the page.

[kolos1, 2017/07/26 13:40:57]

As discussed in person, let's put the question to the team meeting agenda.

+  else if (is_update)
+    passwords_data_.OnUpdatePassword(std::move(form_manager));
+  else
+    passwords_data_.OnPendingPassword(std::move(form_manager));
+  UpdateBubbleAndIconVisibility();
+}
+
+void ManagePasswordsUIController::OnHideManualFallback() {
+  if (passwords_data_.state() != password_manager::ui::PENDING_PASSWORD_STATE &&
+      passwords_data_.state() !=
+          password_manager::ui::PENDING_PASSWORD_UPDATE_STATE &&
+      passwords_data_.state() != password_manager::ui::CONFIRMATION_STATE) {
+    return;
+  }
+
+  passwords_data_.TransitionToState(password_manager::ui::MANAGE_STATE);
+  UpdateBubbleAndIconVisibility();
+}
+
 bool ManagePasswordsUIController::OnChooseCredentials(
     std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials,
     const GURL& origin,