Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Side by Side Diff: components/password_manager/core/common/password_manager_features.cc

Issue 2915763003: [Password Manager] Show omnibox icon and anchored prompt once user start typing password (Closed)
Patch Set: Sent For Review Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/password_manager/core/common/password_manager_features.h" 5 #include "components/password_manager/core/common/password_manager_features.h"
6 6
7 namespace password_manager { 7 namespace password_manager {
8 8
9 namespace features { 9 namespace features {
10 10
11 // Enable affiliation based matching, so that credentials stored for an Android 11 // Enable affiliation based matching, so that credentials stored for an Android
12 // application will also be considered matches for, and be filled into 12 // application will also be considered matches for, and be filled into
13 // corresponding Web applications. 13 // corresponding Web applications.
14 const base::Feature kAffiliationBasedMatching = { 14 const base::Feature kAffiliationBasedMatching = {
15 "affiliation-based-matching", base::FEATURE_ENABLED_BY_DEFAULT}; 15 "affiliation-based-matching", base::FEATURE_ENABLED_BY_DEFAULT};
16 16
17 // Drop the sync credential if captured for saving, do not offer it for saving. 17 // Drop the sync credential if captured for saving, do not offer it for saving.
18 const base::Feature kDropSyncCredential = {"drop-sync-credential", 18 const base::Feature kDropSyncCredential = {"drop-sync-credential",
19 base::FEATURE_ENABLED_BY_DEFAULT}; 19 base::FEATURE_ENABLED_BY_DEFAULT};
20 20
21 // Show the omnibox icon once a user starts typing in a password field.
22 const base::Feature kEnableManualFallbackForSaving = {
23 "enable-manual-fallback-for-password-saving",
vasilii 2017/07/21 12:48:21 The documentation asks to use CamelCase for the na
kolos1 2017/07/24 15:33:31 Not sure I understand you. A name of constant sho
vasilii 2017/07/25 11:17:46 I commented on "enable-manual-fallback-for-passwor
kolos1 2017/07/26 13:40:57 Changes in this file are reverted.
24 base::FEATURE_DISABLED_BY_DEFAULT};
25
21 // Enable a context menu item in the password field that allows the user 26 // Enable a context menu item in the password field that allows the user
22 // to manually enforce saving of their password. 27 // to manually enforce saving of their password.
23 const base::Feature kEnablePasswordForceSaving = { 28 const base::Feature kEnablePasswordForceSaving = {
24 "enable-password-force-saving", base::FEATURE_DISABLED_BY_DEFAULT}; 29 "enable-password-force-saving", base::FEATURE_DISABLED_BY_DEFAULT};
25 30
26 // Enable the user to trigger password generation manually. 31 // Enable the user to trigger password generation manually.
27 extern const base::Feature kEnableManualPasswordGeneration = { 32 extern const base::Feature kEnableManualPasswordGeneration = {
28 "enable-manual-password-generation", base::FEATURE_DISABLED_BY_DEFAULT}; 33 "enable-manual-password-generation", base::FEATURE_DISABLED_BY_DEFAULT};
29 34
30 // Enables username correction while saving username and password details. 35 // Enables username correction while saving username and password details.
(...skipping 19 matching lines...) Expand all
50 base::FEATURE_DISABLED_BY_DEFAULT}; 55 base::FEATURE_DISABLED_BY_DEFAULT};
51 56
52 // Enables the experiment for the password manager to only fill on account 57 // Enables the experiment for the password manager to only fill on account
53 // selection, rather than autofilling on page load, with highlighting of fields. 58 // selection, rather than autofilling on page load, with highlighting of fields.
54 const base::Feature kFillOnAccountSelect = {"fill-on-account-select", 59 const base::Feature kFillOnAccountSelect = {"fill-on-account-select",
55 base::FEATURE_DISABLED_BY_DEFAULT}; 60 base::FEATURE_DISABLED_BY_DEFAULT};
56 61
57 } // namespace features 62 } // namespace features
58 63
59 } // namespace password_manager 64 } // namespace password_manager
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698