Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: components/password_manager/core/common/password_manager_features.cc

Issue 2915763003: [Password Manager] Show omnibox icon and anchored prompt once user start typing password (Closed)
Patch Set: Sent For Review Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/common/password_manager_features.cc
diff --git a/components/password_manager/core/common/password_manager_features.cc b/components/password_manager/core/common/password_manager_features.cc
index 5dce1e7eba2e0c43a4eb3f0a003303966235c753..62b61c38dcc112ffa7329418a675404cc96839d2 100644
--- a/components/password_manager/core/common/password_manager_features.cc
+++ b/components/password_manager/core/common/password_manager_features.cc
@@ -18,6 +18,11 @@ const base::Feature kAffiliationBasedMatching = {
const base::Feature kDropSyncCredential = {"drop-sync-credential",
base::FEATURE_ENABLED_BY_DEFAULT};
+// Show the omnibox icon once a user starts typing in a password field.
+const base::Feature kEnableManualFallbackForSaving = {
+ "enable-manual-fallback-for-password-saving",
vasilii 2017/07/21 12:48:21 The documentation asks to use CamelCase for the na
kolos1 2017/07/24 15:33:31 Not sure I understand you. A name of constant sho
vasilii 2017/07/25 11:17:46 I commented on "enable-manual-fallback-for-passwor
kolos1 2017/07/26 13:40:57 Changes in this file are reverted.
+ base::FEATURE_DISABLED_BY_DEFAULT};
+
// Enable a context menu item in the password field that allows the user
// to manually enforce saving of their password.
const base::Feature kEnablePasswordForceSaving = {

Powered by Google App Engine
This is Rietveld 408576698