[Password Manager] Show omnibox icon and anchored prompt once user start typing password

components/password_manager/core/browser/password_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/core/browser/password_manager.h"
 
 #include <stddef.h>
 #include <map>
 #include <utility>
 
@@ skipping 119 matching lines @@
   }
 
   return PreferredRealmIsFromAndroid(fill_data);
 }
 
 bool AreAllFieldsEmpty(const PasswordForm& form) {
   return form.username_value.empty() && form.password_value.empty() &&
          form.new_password_value.empty();
 }
 
+bool IsPasswordUpdate(const PasswordFormManager& provisional_save_manager) {

[vasilii, 2017/07/21 12:48:20]

Comment?

[kolos1, 2017/07/24 15:33:30]

Done.

+  return (!provisional_save_manager.best_matches().empty() &&
+          provisional_save_manager
+              .is_possible_change_password_form_without_username()) ||
+         provisional_save_manager.password_overridden() ||
+         provisional_save_manager.retry_password_form_password_update();
+}
+
 }  // namespace
 
 // static
 void PasswordManager::RegisterProfilePrefs(
     user_prefs::PrefRegistrySyncable* registry) {
 #if defined(OS_IOS) || defined(OS_ANDROID)
   uint32_t flags = PrefRegistry::NO_REGISTRATION_FLAGS;
 #else
   uint32_t flags = user_prefs::PrefRegistrySyncable::SYNCABLE_PREF;
 #endif
@@ skipping 313 matching lines @@
     password_manager::PasswordManagerDriver* driver,
     const PasswordForm& password_form) {
   // TODO(msramek): This is just a sketch. We will need to show a custom bubble,
   // mark the form as force saved, and recreate the pending login managers,
   // because the password store might have changed.
   ProvisionallySavePassword(password_form, driver);
   if (provisional_save_manager_)
     OnLoginSuccessful();
 }
 
+void PasswordManager::ShowManualFallback(
+    password_manager::PasswordManagerDriver* driver,
+    const PasswordForm& password_form) {
+  ProvisionallySavePassword(password_form, driver);
+  DCHECK(provisional_save_manager_);
+  DCHECK(provisional_save_manager_->form_fetcher());
+  // TODO(crbug.com/741537): Process manual saving request even if there is
+  // still no response from the store.
+  if (provisional_save_manager_->form_fetcher()->GetState() !=

[vasilii, 2017/07/21 12:48:20]

== WAITING?

[kolos1, 2017/07/24 15:33:30]

Done.

+      FormFetcher::State::NOT_WAITING) {
+    return;
+  }
+  bool is_update = IsPasswordUpdate(*provisional_save_manager_);
+  client_->ShowManualFallback(std::move(provisional_save_manager_), is_update);
+}
+
+void PasswordManager::HideManualFallback() {
+  client_->HideManualFallback();
+}
+
 void PasswordManager::OnPasswordFormsParsed(
     password_manager::PasswordManagerDriver* driver,
     const std::vector<PasswordForm>& forms) {
   CreatePendingLoginManagers(driver, forms);
 }
 
 void PasswordManager::CreatePendingLoginManagers(
     password_manager::PasswordManagerDriver* driver,
     const std::vector<PasswordForm>& forms) {
   std::unique_ptr<BrowserSavePasswordProgressLogger> logger;
@@ skipping 263 matching lines @@
 
   RecordWhetherTargetDomainDiffers(main_frame_url_, client_->GetMainFrameURL());
 
   if (ShouldPromptUserToSavePassword()) {
     bool empty_password =
         provisional_save_manager_->pending_credentials().username_value.empty();
     UMA_HISTOGRAM_BOOLEAN("PasswordManager.EmptyUsernames.OfferedToSave",
                           empty_password);
     if (logger)
       logger->LogMessage(Logger::STRING_DECISION_ASK);
-    bool update_password =
-        (!provisional_save_manager_->best_matches().empty() &&
-         provisional_save_manager_
-             ->is_possible_change_password_form_without_username()) ||
-        provisional_save_manager_->password_overridden() ||
-        provisional_save_manager_->retry_password_form_password_update();
+    bool update_password = IsPasswordUpdate(*provisional_save_manager_);
     if (client_->PromptUserToSaveOrUpdatePassword(
             std::move(provisional_save_manager_), update_password)) {
       if (logger)
         logger->LogMessage(Logger::STRING_SHOW_PASSWORD_PROMPT);
     }
   } else {
     if (logger)
       logger->LogMessage(Logger::STRING_DECISION_SAVE);
     provisional_save_manager_->Save();
 
@@ skipping 156 matching lines @@
       current_match_result = result;
     } else if (result > current_match_result) {
       matched_manager = login_manager.get();
       current_match_result = result;
     }
   }
   return matched_manager;
 }
 
 }  // namespace password_manager