Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: components/password_manager/core/browser/password_manager_driver.h

Issue 2915763003: [Password Manager] Show omnibox icon and anchored prompt once user start typing password (Closed)
Patch Set: Sent For Review Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_DRIVER_H_ 5 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_DRIVER_H_
6 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_DRIVER_H_ 6 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_DRIVER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 virtual void ShowInitialPasswordAccountSuggestions( 71 virtual void ShowInitialPasswordAccountSuggestions(
72 const autofill::PasswordFormFillData& form_data) = 0; 72 const autofill::PasswordFormFillData& form_data) = 0;
73 73
74 // Tells the driver to clear previewed password and username fields. 74 // Tells the driver to clear previewed password and username fields.
75 virtual void ClearPreviewedForm() = 0; 75 virtual void ClearPreviewedForm() = 0;
76 76
77 // Tells the driver to find the focused password field and report back 77 // Tells the driver to find the focused password field and report back
78 // the corresponding password form, so that it can be saved. 78 // the corresponding password form, so that it can be saved.
79 virtual void ForceSavePassword() {} 79 virtual void ForceSavePassword() {}
80 80
81 // Tells the driver to show the manual fallback for password saving, i.e. to
vasilii 2017/07/21 12:48:21 Who tells whom? I think PasswordManagerDriver does
kolos1 2017/07/24 15:33:30 "Tells the driver..." is pattern for comments for
82 // show the omnibox icon with anchored hidden save prompt.
83 virtual void ShowManualFallback(const autofill::PasswordForm& form) {}
84
85 // Tells the driver to hide the manual fallback for saving.
86 virtual void HideManualFallback() {}
87
81 // Tells the driver to find the focused password field and to show generation 88 // Tells the driver to find the focused password field and to show generation
82 // popup at it. 89 // popup at it.
83 virtual void GeneratePassword() {} 90 virtual void GeneratePassword() {}
84 91
85 // Returns the PasswordGenerationManager associated with this instance. 92 // Returns the PasswordGenerationManager associated with this instance.
86 virtual PasswordGenerationManager* GetPasswordGenerationManager() = 0; 93 virtual PasswordGenerationManager* GetPasswordGenerationManager() = 0;
87 94
88 // Returns the PasswordManager associated with this instance. 95 // Returns the PasswordManager associated with this instance.
89 virtual PasswordManager* GetPasswordManager() = 0; 96 virtual PasswordManager* GetPasswordManager() = 0;
90 97
(...skipping 13 matching lines...) Expand all
104 // Return true iff the driver corresponds to the main frame. 111 // Return true iff the driver corresponds to the main frame.
105 virtual bool IsMainFrame() const = 0; 112 virtual bool IsMainFrame() const = 0;
106 113
107 private: 114 private:
108 DISALLOW_COPY_AND_ASSIGN(PasswordManagerDriver); 115 DISALLOW_COPY_AND_ASSIGN(PasswordManagerDriver);
109 }; 116 };
110 117
111 } // namespace password_manager 118 } // namespace password_manager
112 119
113 #endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_DRIVER_H_ 120 #endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_DRIVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698