Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2915753003: [Night Light] CL5: Schedule Settings (Closed)

Created:
3 years, 6 months ago by afakhry
Modified:
3 years, 6 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dcheng, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, James Cook
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Night Light] CL5: Schedule Settings Adds the Night Light automatic schedule settings. Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=705816#c15 BUG=705816 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2915753003 Cr-Commit-Position: refs/heads/master@{#478767} Committed: https://chromium.googlesource.com/chromium/src/+/74520997b5744e0c8a1684cc9cf0b18f9f60926c

Patch Set 1 #

Patch Set 2 : Fix styles, prevent label overlaps #

Patch Set 3 : Hook prefs behavior [WIP] #

Patch Set 4 : Rebase #

Patch Set 5 : Hook it up. #

Patch Set 6 : Fix bugs, keyboard keys, overlap threshold #

Patch Set 7 : Fully working (minus documentations and comments) #

Patch Set 8 : Ready for review #

Total comments: 12

Patch Set 9 : Steven's initial comments #

Total comments: 20

Patch Set 10 : Steven's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+724 lines, -0 lines) Patch
M chrome/app/settings_strings.grdp View 1 2 3 4 5 6 7 8 9 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/settings_private/prefs_util.cc View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/device_page/compiled_resources2.gyp View 1 2 3 4 5 6 7 8 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/device_page/display.html View 1 2 3 4 5 6 7 8 9 3 chunks +29 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/device_page/display.js View 1 2 3 4 5 3 chunks +43 lines, -0 lines 0 comments Download
A chrome/browser/resources/settings/device_page/night_light_slider.html View 1 2 3 4 5 6 7 8 9 1 chunk +163 lines, -0 lines 0 comments Download
A chrome/browser/resources/settings/device_page/night_light_slider.js View 1 2 3 4 5 6 7 8 9 1 chunk +449 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 2 3 4 5 6 7 8 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/data/webui/settings/device_page_tests.js View 1 2 3 4 5 6 7 8 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 45 (37 generated)
afakhry
stevenjb@, could you please review this CL? CC jamescook@ FYI.
3 years, 6 months ago (2017-06-09 00:42:14 UTC) #22
stevenjb
I haven't had a chance to review the JS or do more than a rough ...
3 years, 6 months ago (2017-06-09 00:56:59 UTC) #23
afakhry
I moved night_light_slider under device_page. https://codereview.chromium.org/2915753003/diff/140001/chrome/browser/resources/settings/controls/night_light_slider.html File chrome/browser/resources/settings/controls/night_light_slider.html (right): https://codereview.chromium.org/2915753003/diff/140001/chrome/browser/resources/settings/controls/night_light_slider.html#newcode12 chrome/browser/resources/settings/controls/night_light_slider.html:12: font-family: Sniglet; On 2017/06/09 ...
3 years, 6 months ago (2017-06-09 17:21:55 UTC) #28
stevenjb
https://codereview.chromium.org/2915753003/diff/160001/chrome/browser/resources/settings/device_page/display.html File chrome/browser/resources/settings/device_page/display.html (right): https://codereview.chromium.org/2915753003/diff/160001/chrome/browser/resources/settings/device_page/display.html#newcode244 chrome/browser/resources/settings/device_page/display.html:244: lable="$i18n{displayNightLightScheduleLabel}" label= (it doesn't like this is needed/used?) https://codereview.chromium.org/2915753003/diff/160001/chrome/browser/resources/settings/device_page/night_light_slider.html ...
3 years, 6 months ago (2017-06-09 22:51:45 UTC) #31
afakhry
https://codereview.chromium.org/2915753003/diff/160001/chrome/browser/resources/settings/device_page/display.html File chrome/browser/resources/settings/device_page/display.html (right): https://codereview.chromium.org/2915753003/diff/160001/chrome/browser/resources/settings/device_page/display.html#newcode244 chrome/browser/resources/settings/device_page/display.html:244: lable="$i18n{displayNightLightScheduleLabel}" On 2017/06/09 22:51:45, stevenjb wrote: > label= (it ...
3 years, 6 months ago (2017-06-12 18:07:09 UTC) #37
stevenjb
lgtm
3 years, 6 months ago (2017-06-12 18:14:35 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2915753003/200001
3 years, 6 months ago (2017-06-12 21:10:44 UTC) #42
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 21:17:00 UTC) #45
Message was sent while issue was closed.
Committed patchset #10 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/74520997b5744e0c8a1684cc9cf0...

Powered by Google App Engine
This is Rietveld 408576698