Tether MessageTransferOperation: Only wait for a response from a host for a certain amount of time …

chromeos/components/tether/disconnect_tethering_operation_unittest.cc

Index: chromeos/components/tether/disconnect_tethering_operation_unittest.cc
diff --git a/chromeos/components/tether/disconnect_tethering_operation_unittest.cc b/chromeos/components/tether/disconnect_tethering_operation_unittest.cc
index cfdac1e5cdf4e10c3da65c96a455b01eb343b358..29b2f7f441c62e2bfff172e01d39d2b96a20b478 100644
--- a/chromeos/components/tether/disconnect_tethering_operation_unittest.cc
+++ b/chromeos/components/tether/disconnect_tethering_operation_unittest.cc
@@ -84,6 +84,8 @@ class DisconnectTetheringOperationTest : public testing::Test {
     operation_->UnregisterDevice(test_device_);
   }
 
+  bool ShouldWaitForResponse() { return operation_->ShouldWaitForResponse(); }
+
   const std::string disconnect_tethering_request_string_;
   const cryptauth::RemoteDevice test_device_;
 
@@ -108,6 +110,10 @@ TEST_F(DisconnectTetheringOperationTest, TestFailure) {
   EXPECT_FALSE(test_observer_->WasLastOperationSuccessful());
 }
 
+TEST_F(DisconnectTetheringOperationTest, TestShouldNotWaitForResponse) {

[Kyle Horimoto, 2017/06/01 18:18:58]

nit: I don't think this test is really necessary. You already test that the
operation is finished in the TestSuccess test above. Since
ShouldWaitForResponse() is so trivial, this test basically just asserts that a
function which returns false returns false, which I don't think provides much
value.

[Ryan Hansberry, 2017/06/01 18:44:09]

Fair enough, removed.

+  EXPECT_FALSE(ShouldWaitForResponse());
+}
+
 }  // namespace tether
 
 }  // namespace cryptauth