Tether MessageTransferOperation: Only wait for a response from a host for a certain amount of time …

chromeos/components/tether/disconnect_tethering_operation_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/components/tether/disconnect_tethering_operation.h"
 
 #include <memory>
 #include <vector>
 
 #include "chromeos/components/tether/fake_ble_connection_manager.h"
@@ skipping 66 matching lines @@
         fake_ble_connection_manager_->sent_messages();
     ASSERT_EQ(1u, sent_messages.size());
     EXPECT_EQ(test_device_, sent_messages[0].remote_device);
     EXPECT_EQ(disconnect_tethering_request_string_, sent_messages[0].message);
   }
 
   void SimulateConnectionTimeout() {
     operation_->UnregisterDevice(test_device_);
   }
 
+  bool ShouldWaitForResponse() { return operation_->ShouldWaitForResponse(); }
+
   const std::string disconnect_tethering_request_string_;
   const cryptauth::RemoteDevice test_device_;
 
   std::unique_ptr<FakeBleConnectionManager> fake_ble_connection_manager_;
   std::unique_ptr<TestObserver> test_observer_;
 
   std::unique_ptr<DisconnectTetheringOperation> operation_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(DisconnectTetheringOperationTest);
 };
 
 TEST_F(DisconnectTetheringOperationTest, TestSuccess) {
   SimulateDeviceAuthenticationAndVerifyMessageSent();
   EXPECT_EQ(test_device_.GetDeviceId(), test_observer_->last_device_id());
   EXPECT_TRUE(test_observer_->WasLastOperationSuccessful());
 }
 
 TEST_F(DisconnectTetheringOperationTest, TestFailure) {
   SimulateConnectionTimeout();
   EXPECT_EQ(test_device_.GetDeviceId(), test_observer_->last_device_id());
   EXPECT_FALSE(test_observer_->WasLastOperationSuccessful());
 }
 
+TEST_F(DisconnectTetheringOperationTest, TestShouldNotWaitForResponse) {

[Kyle Horimoto, 2017/06/01 18:18:58]

nit: I don't think this test is really necessary. You already test that the
operation is finished in the TestSuccess test above. Since
ShouldWaitForResponse() is so trivial, this test basically just asserts that a
function which returns false returns false, which I don't think provides much
value.

[Ryan Hansberry, 2017/06/01 18:44:09]

Fair enough, removed.

+  EXPECT_FALSE(ShouldWaitForResponse());
+}
+
 }  // namespace tether
 
 }  // namespace cryptauth