Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2915683002: Generate enum/getters/setters/mappings for ruby-position. (Closed)

Created:
3 years, 6 months ago by shend
Modified:
3 years, 6 months ago
Reviewers:
dstockwell
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate enum/getters/setters/mappings for ruby-position. Currently, the ruby-position property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to a 'keyword' field so that its getters/setters can be generated as well. We also generate the ERubyPosition enum and use the generated CSSValueID <-> ERubyPosition mappings. BUG=628043 Review-Url: https://codereview.chromium.org/2915683002 Cr-Commit-Position: refs/heads/master@{#475817} Committed: https://chromium.googlesource.com/chromium/src/+/4e4c61cfefb77952159dae7efab12914e9f4e56f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -43 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +0 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
shend
Hi Eddy, PTAL
3 years, 6 months ago (2017-05-30 23:31:02 UTC) #3
shend
Hi Doug, PTAL
3 years, 6 months ago (2017-05-31 04:02:16 UTC) #8
dstockwell
lgtm
3 years, 6 months ago (2017-05-31 05:26:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2915683002/1
3 years, 6 months ago (2017-05-31 05:47:00 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 05:50:58 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4e4c61cfefb77952159dae7efab1...

Powered by Google App Engine
This is Rietveld 408576698