Do not use CRWWebController in FormSuggestionControllerTest.

Do not use CRWWebController in FormSuggestionControllerTest.

CRWWebController was used to mock contentIsHTML method, which is a
private implementation method of ios/web. This test instead loads a PDF
file to make contentIsHTML return NO.

BUG=619783
Review-Url: https://codereview.chromium.org/2915603002
Cr-Commit-Position: refs/heads/master@{#476875}
Committed: https://chromium.googlesource.com/chromium/src/+/76a788a1e25c6cfd167abdf491922917c1a5b9ac

[Eugene But (OOO till 7-30), 2017-05-30 15:43:44]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 15:44:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 15:56:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 15:56:26]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Eugene But (OOO till 7-30), 2017-05-30 21:12:36]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 21:12:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 00:34:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 00:34:44]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-05-31 14:41:31]

eugenebut@chromium.org changed reviewers:
+ bondd@chromium.org

[Eugene But (OOO till 7-30), 2017-05-31 14:41:32]

PTAL

[bondd, 2017-05-31 15:08:23]

Description was changed from

==========
Do not use CRWWebController in FormSuggestionControllerTest.

CRWWebController was used to mock contentIsHTML method, which is a
private implementation method of ios/web. This test instead loads a PDF
file to make contentIsHTML return NO.

BUG=619783
==========

to

==========
Do not use CRWWebController in FormSuggestionControllerTest.

CRWWebController was used to mock contentIsHTML method, which is a
private implementation method of ios/web. This test instead loads a PDF
file to make contentIsHTML return NO.

BUG=619783
==========

[bondd, 2017-05-31 15:08:23]

bondd@chromium.org changed reviewers:
+ jdonnelly@chromium.org
- bondd@chromium.org

[Eugene But (OOO till 7-30), 2017-06-02 16:38:43]

On 2017/05/31 14:41:32, Eugene But wrote:
> PTAL
Justin?

[Justin Donnelly, 2017-06-02 19:32:22]

On 2017/06/02 16:38:43, Eugene But wrote:
> On 2017/05/31 14:41:32, Eugene But wrote:
> > PTAL
> Justin?

Sorry, for some reason, I was never sent an email for the previous comment (I
even checked the junk folder.)

Anyhow, very elegant solution. lgtm!

[Eugene But (OOO till 7-30), 2017-06-02 21:58:48]

On 2017/06/02 19:32:22, Justin Donnelly wrote:
> On 2017/06/02 16:38:43, Eugene But wrote:
> > On 2017/05/31 14:41:32, Eugene But wrote:
> > > PTAL
> > Justin?
> 
> Sorry, for some reason, I was never sent an email for the previous comment (I
> even checked the junk folder.)
> 
> Anyhow, very elegant solution. lgtm!
No worries. Thanks for review.

[Eugene But (OOO till 7-30), 2017-06-02 21:58:55]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2017-06-02 21:59:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-03 01:33:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-03 01:33:40]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Eugene But (OOO till 7-30), 2017-06-03 01:36:41]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2017-06-03 01:37:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-03 02:59:46]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496453801285030,
"parent_rev": "3f9e6d5f978cfe76acff68fb181730b26a4612b1", "commit_rev":
"76a788a1e25c6cfd167abdf491922917c1a5b9ac"}

[commit-bot: I haz the power, 2017-06-03 02:59:54]

Description was changed from

==========
Do not use CRWWebController in FormSuggestionControllerTest.

CRWWebController was used to mock contentIsHTML method, which is a
private implementation method of ios/web. This test instead loads a PDF
file to make contentIsHTML return NO.

BUG=619783
==========

to

==========
Do not use CRWWebController in FormSuggestionControllerTest.

CRWWebController was used to mock contentIsHTML method, which is a
private implementation method of ios/web. This test instead loads a PDF
file to make contentIsHTML return NO.

BUG=619783

Review-Url: https://codereview.chromium.org/2915603002
Cr-Commit-Position: refs/heads/master@{#476875}
Committed:
https://chromium.googlesource.com/chromium/src/+/76a788a1e25c6cfd167abdf49192...
==========

[commit-bot: I haz the power, 2017-06-03 02:59:55]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/76a788a1e25c6cfd167abdf49192...