Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2915553004: mash: Remove last WmWindow uses in ash/shelf. (Closed)

Created:
3 years, 6 months ago by msw
Modified:
3 years, 6 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Remove last WmWindow uses in ash/shelf. BUG=722551 TEST=Compiles; no behavior changes. R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2915553004 Cr-Commit-Position: refs/heads/master@{#475711} Committed: https://chromium.googlesource.com/chromium/src/+/ca7526effd33b9d60760f5fc1d361830243a71c3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -14 lines) Patch
M ash/shelf/overflow_bubble_view.cc View 2 chunks +1 line, -3 lines 0 comments Download
M ash/shelf/shelf.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shelf/shelf_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shelf/shelf_view.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ash/shelf/shelf_widget_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shelf/shelf_window_watcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shelf/shelf_window_watcher_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/shelf_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
msw
Hey James, please take a look; thanks!
3 years, 6 months ago (2017-05-30 22:41:34 UTC) #2
James Cook
LGTM
3 years, 6 months ago (2017-05-30 23:09:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2915553004/1
3 years, 6 months ago (2017-05-31 00:47:28 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 00:53:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ca7526effd33b9d60760f5fc1d36...

Powered by Google App Engine
This is Rietveld 408576698