Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2915553002:
Add BrowserGpuMemoryBufferManager::BufferInfo::shared_memory_guid (Closed)
|
Created:
3 years, 6 months ago by hajimehoshi Modified:
3 years, 6 months ago Reviewers:
jbauman CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, erikchen, ssid, Primiano Tucci (use gerrit) Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd BrowserGpuMemoryBufferManager::BufferInfo::shared_memory_guid
This CL adds a base::SharedMemory's GUID member to
BrowserGpuMemoryBufferManager::BufferInfo. The member will be used by
BrowserGpuMemoryBufferManager when OnMemoryDump is called to create
base::SharedMemory dumps.
This is part of work for exposing SharedMemory usages on tracing
memory-infra dumps.
Design doc: https://docs.google.com/document/d/16Mi5_puxKgQ-9IX7ANfbji0WiqBCK3yrnJ0Qi2wa3w0/edit#heading=h.lofdeze1a2hr
BUG=604726
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2915553002
Cr-Commit-Position: refs/heads/master@{#477219}
Committed: https://chromium.googlesource.com/chromium/src/+/b830638222fafa471d9fc88cf18884cb8952e849
Patch Set 1 #Patch Set 2 : impl #Patch Set 3 : impl #
Messages
Total messages: 29 (22 generated)
Description was changed from ========== [Not ready for review] Add BrowserGpuMemoryBufferManager::BufferInfo::shared_memory_guid This CL adds a base::SharedMemory's GUID member to BrowserGpuMemoryBufferManager::BufferInfo. The member will be used by BrowserGpuMemoryBufferManager when OnMemoryDump is called to create base::SharedMemory dumps. This is part of work for exposing SharedMemory usages on tracing memory-infra dumps. Design doc: https://docs.google.com/document/d/16Mi5_puxKgQ-9IX7ANfbji0WiqBCK3yrnJ0Qi2wa3... BUG=604726 ========== to ========== [Not ready for review] Add BrowserGpuMemoryBufferManager::BufferInfo::shared_memory_guid This CL adds a base::SharedMemory's GUID member to BrowserGpuMemoryBufferManager::BufferInfo. The member will be used by BrowserGpuMemoryBufferManager when OnMemoryDump is called to create base::SharedMemory dumps. This is part of work for exposing SharedMemory usages on tracing memory-infra dumps. Design doc: https://docs.google.com/document/d/16Mi5_puxKgQ-9IX7ANfbji0WiqBCK3yrnJ0Qi2wa3... BUG=604726 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by hajimehoshi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [Not ready for review] Add BrowserGpuMemoryBufferManager::BufferInfo::shared_memory_guid This CL adds a base::SharedMemory's GUID member to BrowserGpuMemoryBufferManager::BufferInfo. The member will be used by BrowserGpuMemoryBufferManager when OnMemoryDump is called to create base::SharedMemory dumps. This is part of work for exposing SharedMemory usages on tracing memory-infra dumps. Design doc: https://docs.google.com/document/d/16Mi5_puxKgQ-9IX7ANfbji0WiqBCK3yrnJ0Qi2wa3... BUG=604726 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== [Not ready for review] Add BrowserGpuMemoryBufferManager::BufferInfo::shared_memory_guid (This change includes https://codereview.chromium.org/2912753002/) This CL adds a base::SharedMemory's GUID member to BrowserGpuMemoryBufferManager::BufferInfo. The member will be used by BrowserGpuMemoryBufferManager when OnMemoryDump is called to create base::SharedMemory dumps. This is part of work for exposing SharedMemory usages on tracing memory-infra dumps. Design doc: https://docs.google.com/document/d/16Mi5_puxKgQ-9IX7ANfbji0WiqBCK3yrnJ0Qi2wa3... BUG=604726 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by hajimehoshi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [Not ready for review] Add BrowserGpuMemoryBufferManager::BufferInfo::shared_memory_guid (This change includes https://codereview.chromium.org/2912753002/) This CL adds a base::SharedMemory's GUID member to BrowserGpuMemoryBufferManager::BufferInfo. The member will be used by BrowserGpuMemoryBufferManager when OnMemoryDump is called to create base::SharedMemory dumps. This is part of work for exposing SharedMemory usages on tracing memory-infra dumps. Design doc: https://docs.google.com/document/d/16Mi5_puxKgQ-9IX7ANfbji0WiqBCK3yrnJ0Qi2wa3... BUG=604726 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== [Not ready for review] Add BrowserGpuMemoryBufferManager::BufferInfo::shared_memory_guid This CL adds a base::SharedMemory's GUID member to BrowserGpuMemoryBufferManager::BufferInfo. The member will be used by BrowserGpuMemoryBufferManager when OnMemoryDump is called to create base::SharedMemory dumps. This is part of work for exposing SharedMemory usages on tracing memory-infra dumps. Design doc: https://docs.google.com/document/d/16Mi5_puxKgQ-9IX7ANfbji0WiqBCK3yrnJ0Qi2wa3... BUG=604726 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
hajimehoshi@chromium.org changed reviewers: + jbauman@chromium.org
PTAL
The CQ bit was checked by hajimehoshi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [Not ready for review] Add BrowserGpuMemoryBufferManager::BufferInfo::shared_memory_guid This CL adds a base::SharedMemory's GUID member to BrowserGpuMemoryBufferManager::BufferInfo. The member will be used by BrowserGpuMemoryBufferManager when OnMemoryDump is called to create base::SharedMemory dumps. This is part of work for exposing SharedMemory usages on tracing memory-infra dumps. Design doc: https://docs.google.com/document/d/16Mi5_puxKgQ-9IX7ANfbji0WiqBCK3yrnJ0Qi2wa3... BUG=604726 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add BrowserGpuMemoryBufferManager::BufferInfo::shared_memory_guid This CL adds a base::SharedMemory's GUID member to BrowserGpuMemoryBufferManager::BufferInfo. The member will be used by BrowserGpuMemoryBufferManager when OnMemoryDump is called to create base::SharedMemory dumps. This is part of work for exposing SharedMemory usages on tracing memory-infra dumps. Design doc: https://docs.google.com/document/d/16Mi5_puxKgQ-9IX7ANfbji0WiqBCK3yrnJ0Qi2wa3... BUG=604726 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Oops, fix this CL's title
lgtm
The CQ bit was checked by hajimehoshi@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by hajimehoshi@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496729393386300,
"parent_rev": "4167dd7b647e54785386b1eebf66a94c3c5ce6db", "commit_rev":
"b830638222fafa471d9fc88cf18884cb8952e849"}
Message was sent while issue was closed.
Description was changed from ========== Add BrowserGpuMemoryBufferManager::BufferInfo::shared_memory_guid This CL adds a base::SharedMemory's GUID member to BrowserGpuMemoryBufferManager::BufferInfo. The member will be used by BrowserGpuMemoryBufferManager when OnMemoryDump is called to create base::SharedMemory dumps. This is part of work for exposing SharedMemory usages on tracing memory-infra dumps. Design doc: https://docs.google.com/document/d/16Mi5_puxKgQ-9IX7ANfbji0WiqBCK3yrnJ0Qi2wa3... BUG=604726 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add BrowserGpuMemoryBufferManager::BufferInfo::shared_memory_guid This CL adds a base::SharedMemory's GUID member to BrowserGpuMemoryBufferManager::BufferInfo. The member will be used by BrowserGpuMemoryBufferManager when OnMemoryDump is called to create base::SharedMemory dumps. This is part of work for exposing SharedMemory usages on tracing memory-infra dumps. Design doc: https://docs.google.com/document/d/16Mi5_puxKgQ-9IX7ANfbji0WiqBCK3yrnJ0Qi2wa3... BUG=604726 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2915553002 Cr-Commit-Position: refs/heads/master@{#477219} Committed: https://chromium.googlesource.com/chromium/src/+/b830638222fafa471d9fc88cf188... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/b830638222fafa471d9fc88cf188... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
