Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: extensions/browser/quota_service.h

Issue 2915523002: Replace deprecated base::NonThreadSafe in extensions in favor of SequenceChecker. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/quota_service.h
diff --git a/extensions/browser/quota_service.h b/extensions/browser/quota_service.h
index 433ea322ac3ad0494814cdc28f9e230a8df130e1..bee241c00e48d2771d0b449e4810f17663e2d9dc 100644
--- a/extensions/browser/quota_service.h
+++ b/extensions/browser/quota_service.h
@@ -24,7 +24,7 @@
#include "base/compiler_specific.h"
#include "base/containers/hash_tables.h"
#include "base/macros.h"
-#include "base/threading/non_thread_safe.h"
+#include "base/sequence_checker.h"
#include "base/time/time.h"
#include "base/timer/timer.h"
#include "base/values.h"
@@ -44,7 +44,7 @@ using QuotaLimitHeuristics = std::list<std::unique_ptr<QuotaLimitHeuristic>>;
// called and destroyed on the same thread, due to its use of a RepeatingTimer.
// It is not a KeyedService because instances exist on both the UI
// and IO threads.
Devlin 2017/05/30 19:06:47 This class is probably better suited for ThreadChe
gab 2017/05/31 17:52:28 Done.
-class QuotaService : public base::NonThreadSafe {
+class QuotaService {
public:
// Some concrete heuristics (declared below) that ExtensionFunctions can
// use to help the service make decisions about quota violations.
@@ -91,6 +91,8 @@ class QuotaService : public base::NonThreadSafe {
// Each heuristic will be evaluated and ANDed together to get a final answer.
std::map<ExtensionId, FunctionHeuristicsMap> function_heuristics_;
+ SEQUENCE_CHECKER(sequence_checker_);
+
DISALLOW_COPY_AND_ASSIGN(QuotaService);
};

Powered by Google App Engine
This is Rietveld 408576698