Replace deprecated base::NonThreadSafe in extensions in favor of SequenceChecker.

extensions/browser/value_store/value_store_frontend.h

Index: extensions/browser/value_store/value_store_frontend.h
diff --git a/extensions/browser/value_store/value_store_frontend.h b/extensions/browser/value_store/value_store_frontend.h
index 015c6f3d7f016b1dc3c1340677f9ad484f30daaf..930e959cfe5f0d69673a73f26d4ef63b697bca86 100644
--- a/extensions/browser/value_store/value_store_frontend.h
+++ b/extensions/browser/value_store/value_store_frontend.h
@@ -12,7 +12,7 @@
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
-#include "base/threading/non_thread_safe.h"
+#include "base/sequence_checker.h"
 #include "base/values.h"
 #include "extensions/browser/value_store/value_store.h"
 
@@ -21,9 +21,7 @@ class ValueStoreFactory;
 }  // namespace extensions
 
 // A frontend for a LeveldbValueStore, for use on the UI thread.

[Devlin, 2017/05/30 19:06:47]

Since this is only designed to be used on the UI thread, probably ThreadChecker.

[gab, 2017/05/31 17:52:28]

I don't see thread-affinity requirements in ValueStoreFrontend's design?
Anyways, added BrowserThread::UI checks for now to match current API comment.

-class ValueStoreFrontend
-    : public base::SupportsWeakPtr<ValueStoreFrontend>,
-      public base::NonThreadSafe {
+class ValueStoreFrontend : public base::SupportsWeakPtr<ValueStoreFrontend> {
  public:
   // The kind of extensions data stored in a backend.
   enum class BackendType { RULES, STATE };
@@ -52,6 +50,8 @@ class ValueStoreFrontend
   // on the FILE thread.
   scoped_refptr<Backend> backend_;
 
+  SEQUENCE_CHECKER(sequence_checker_);
+
   DISALLOW_COPY_AND_ASSIGN(ValueStoreFrontend);
 };