Support PermissionRequestManager for multiple download permissions on Android

Support PermissionRequestManager for multiple download permissions on Android

This patch makes the DownloadRequestLimiter call into on Android the
PermissionRequestManager on Android. Note that this means that these
permission requests, which currently only use infobars on Android, will
be shown as modal dialogs when that feature and the PRM are enabled.

BUG=606138
Review-Url: https://codereview.chromium.org/2915503003
Cr-Commit-Position: refs/heads/master@{#478898}
Committed: https://chromium.googlesource.com/chromium/src/+/178801f31a4a630c65e0078b5dcb4af07b580fb7

[Timothy Loh, 2017-05-30 08:00:11]

The CQ bit was checked by timloh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 08:00:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Timothy Loh, 2017-05-30 08:01:24]

timloh@chromium.org changed reviewers:
+ raymes@chromium.org

[commit-bot: I haz the power, 2017-05-30 09:27:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 09:27:30]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[raymes, 2017-05-31 02:55:21]

raymes@chromium.org changed reviewers:
+ dominickn@chromium.org

[raymes, 2017-05-31 02:55:21]

lgtm but +dominickn as FYI

When we get closer to modals being shipped we will need to go through exactly
what prompts will be affected and have them signed off on. It would be possible
that we still want to keep some prompts as infobars but we can address that at
that point.

[Timothy Loh, 2017-06-05 02:38:16]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2017-06-05 02:38:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 02:47:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 02:47:01]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Timothy Loh, 2017-06-06 03:19:02]

timloh@chromium.org changed reviewers:
+ dtrainor@chromium.org

[Timothy Loh, 2017-06-06 03:19:03]

+dtrainor for chrome/browser/download OWNERS

[David Trainor- moved to gerrit, 2017-06-07 06:05:51]

I hadn't heard that we were moving all of these infobars over to modal prompts. 
The bug just seems to talk about unifying the back-end.  Do we have UX approval
for this kind of larger scoped change?  It looks like the plan is to migrate all
of these downloads permissions right?  Just want to check before I give the all
clear! :)

[Timothy Loh, 2017-06-07 06:49:16]

On 2017/06/07 06:05:51, David Trainor-OOO to 6-8 wrote:
> I hadn't heard that we were moving all of these infobars over to modal
prompts. 
> The bug just seems to talk about unifying the back-end.  Do we have UX
approval
> for this kind of larger scoped change?  It looks like the plan is to migrate
all
> of these downloads permissions right?  Just want to check before I give the
all
> clear! :)

The bug and this patch are indeed about unifying the back-end, making both
desktop and android use the PermissionRequestManager. It's currently disabled on
android so this patch doesn't actually change any UI yet, but once it's done and
shipped we'll use DownloadPermissionRequest everywhere and remove
DownloadRequestInfoBarDelegateAndroid. The requests going through the PRM can be
shown by either infobars or modals.

Modals are currently running in a finch experiment (I think 1% have modals and
1% have modals on gesture), and we're planning on shipping it some time soon
(dominickn@ is leading the modal effort). As raymes@ said earlier, we still need
to decide exactly which permissions we'll use modals for and which won't.

[dominickn, 2017-06-07 06:53:28]

dtrainor: modal permission prompts are about to go to UI/Launch review after
running in an experiment in M57. Like timloh said, the actual UX displayed
(infobar or modal) is independent of whether we use the PermissionRequestManager
backend or the existing Android backend.

[David Trainor- moved to gerrit, 2017-06-09 06:59:06]

lgtm thanks!  sorry for the delays was ooo!

[Timothy Loh, 2017-06-13 02:42:00]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2017-06-13 02:42:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 04:18:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497321720177370, "parent_rev":
"f86ff4e07ecc10e97d9c677b44b1a46d91d1caf3", "commit_rev":
"178801f31a4a630c65e0078b5dcb4af07b580fb7"}

[commit-bot: I haz the power, 2017-06-13 04:18:13]

Description was changed from

==========
Support PermissionRequestManager for multiple download permissions on Android

This patch makes the DownloadRequestLimiter call into on Android the
PermissionRequestManager on Android. Note that this means that these
permission requests, which currently only use infobars on Android, will
be shown as modal dialogs when that feature and the PRM are enabled.

BUG=606138
==========

to

==========
Support PermissionRequestManager for multiple download permissions on Android

This patch makes the DownloadRequestLimiter call into on Android the
PermissionRequestManager on Android. Note that this means that these
permission requests, which currently only use infobars on Android, will
be shown as modal dialogs when that feature and the PRM are enabled.

BUG=606138

Review-Url: https://codereview.chromium.org/2915503003
Cr-Commit-Position: refs/heads/master@{#478898}
Committed:
https://chromium.googlesource.com/chromium/src/+/178801f31a4a630c65e0078b5dcb...
==========

[commit-bot: I haz the power, 2017-06-13 04:18:15]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/178801f31a4a630c65e0078b5dcb...